Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31810

Not closed '</div' tag in several views

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.2.4, 2.3.1, 2.4
    • 2.2.5, 2.3.2
    • Reports
    • Any
    • MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • MOODLE_22_STABLE, MOODLE_23_STABLE
    • wip-MDL-31810-master
    • Hide

      None, just close '</div' -> into '</div>'

      Show
      None, just close '</div' -> into '</div>'
    • Easy
    • Hide
      • Click on: Site administration > Reports > Statistics
      • Select a course in first combo
      • Select a long time period, for example '6 months'
      • Click 'View'
      • In the top-right corner select 'Detailed (user) view' instead of 'General view'
      • See normal navigation bar on the left
      Show
      Click on: Site administration > Reports > Statistics Select a course in first combo Select a long time period, for example '6 months' Click 'View' In the top-right corner select 'Detailed (user) view' instead of 'General view' See normal navigation bar on the left

    Description

      There are some minor problems, easily fixable in Moodle 2.1 and 2.2 (which I have installed/used).

      Namely, there are some code snippets which contain not completely closed '</div' tag.

      I have found this problem in Moodle 2.1:

      • [$MOODLE]/course/report/stats/report.php
      • [$MOODLE]/mod/feedback/show_nonrespondents.php (at least in some older version, not necessarily in 2.1 STABLE)

      The same applies to Moodle 2.2:

      • [$MOODLE]/report/stats/locallib.php

      The most visible impact is on statistics report (for a course), after selecting in top-right corner a "Detailed (user) view" ($string['statsmodedetailed']).

      Attachments

        Issue Links

          Activity

            People

              phalacee Jason Fowler
              wiktorw Wiktor Wandachowicz
              Dan Poltawski Dan Poltawski
              Dan Poltawski Dan Poltawski
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Sep/12