Moodle
  1. Moodle
  2. MDL-31810

Not closed '</div' tag in several views

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Reports
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide
      • Click on: Site administration > Reports > Statistics
      • Select a course in first combo
      • Select a long time period, for example '6 months'
      • Click 'View'
      • In the top-right corner select 'Detailed (user) view' instead of 'General view'
      • See normal navigation bar on the left
      Show
      Click on: Site administration > Reports > Statistics Select a course in first combo Select a long time period, for example '6 months' Click 'View' In the top-right corner select 'Detailed (user) view' instead of 'General view' See normal navigation bar on the left
    • Workaround:
      Hide

      None, just close '</div' -> into '</div>'

      Show
      None, just close '</div' -> into '</div>'
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-MDL-31810-master
    • Rank:
      38439

      Description

      There are some minor problems, easily fixable in Moodle 2.1 and 2.2 (which I have installed/used).

      Namely, there are some code snippets which contain not completely closed '</div' tag.

      I have found this problem in Moodle 2.1:

      • [$MOODLE]/course/report/stats/report.php
      • [$MOODLE]/mod/feedback/show_nonrespondents.php (at least in some older version, not necessarily in 2.1 STABLE)

      The same applies to Moodle 2.2:

      • [$MOODLE]/report/stats/locallib.php

      The most visible impact is on statistics report (for a course), after selecting in top-right corner a "Detailed (user) view" ($string['statsmodedetailed']).

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for spotting that and directing us to a solution.

          Show
          Michael de Raadt added a comment - Thanks for spotting that and directing us to a solution.
          Hide
          Saswat Padhi added a comment -

          I ran a regex "<//div[^>]" over all 22_STABLE files.
          The reported file is the only file with this issue.

          Show
          Saswat Padhi added a comment - I ran a regex "< // div [^>] " over all 22_STABLE files. The reported file is the only file with this issue.
          Hide
          Jason Fowler added a comment -

          skipping peer review, as it is simply fixing HTML tags, there is no logic

          Show
          Jason Fowler added a comment - skipping peer review, as it is simply fixing HTML tags, there is no logic
          Hide
          Dan Poltawski added a comment -

          Integrated to 23, 22 and master, thanks guys.

          Show
          Dan Poltawski added a comment - Integrated to 23, 22 and master, thanks guys.
          Hide
          Dan Poltawski added a comment -

          There was an E_STRICT problem causing the graphs not to display. Its a shame that was not fixed whilst working on this, but i've created a new issue for that. (MDL-35006)

          Show
          Dan Poltawski added a comment - There was an E_STRICT problem causing the graphs not to display. Its a shame that was not fixed whilst working on this, but i've created a new issue for that. ( MDL-35006 )
          Hide
          Eloy Lafuente (stronk7) added a comment -

          YEAR!*

          CAF*, TOT!*

          • Your effort amazingly resulted. (unbelievable :-P)
          • Closing as fixed.
          • Tons of thanks.
          Show
          Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: