Moodle
  1. Moodle
  2. MDL-31812

Items in manifest rendered as link, even though they don't refer to a resource

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.2.1
    • Fix Version/s: None
    • Component/s: IMS-CP resource type
    • Labels:
    • Environment:
      Debian
    • Testing Instructions:
      Hide

      Load a IMS-CP package which includes items with no resource ("identifierref" attribute). View it.

      If the following are true, the fix worked:
      1. The first item with a resource is displayed when the IMSCP is viewed.
      2. Items without resources are non-linked plain text.
      3. Clicking on an item without resources displays a list of child node titles in the content area.
      4. Clicking one of child nodes listed loads the corresponding item (with or without resource) in the in the content area.

      Show
      Load a IMS-CP package which includes items with no resource ("identifierref" attribute). View it. If the following are true, the fix worked: 1. The first item with a resource is displayed when the IMSCP is viewed. 2. Items without resources are non-linked plain text. 3. Clicking on an item without resources displays a list of child node titles in the content area. 4. Clicking one of child nodes listed loads the corresponding item (with or without resource) in the in the content area.
    • Workaround:
      Hide

      Apply attached patch.

      Show
      Apply attached patch.
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      38442

      Description

      View a IM-CP which includes items with no resource ("identifierref" attribute).

      When rendered, every branch and leaf is output as a link - even when there is no resource to link to specified in the manifest.

      Expected results: items without resources are rendered as non-linked plain text.

      Actual results: items without resources are rendered as links.

      Patch to fix this attached.

      1. imscp_only-link-resources.patch
        1 kB
        David Balch
      2. ims-navigation.patch
        5 kB
        David Balch

        Activity

        David Balch created issue -
        David Balch made changes -
        Field Original Value New Value
        Labels patch
        David Balch made changes -
        Testing Instructions Load a IMS-CP package which includes items with no resource ("identifierref" attribute). View it.

        If items without resources are non-linked plain text, the fix worked.
        Load a IMS-CP package which includes items with no resource ("identifierref" attribute). View it.

        If the following are true, the fix worked:
         1. items without resources are non-linked plain text, and do not react when clicked
         2. The first item with a resource is displayed in the content area.
        Michael de Raadt made changes -
        Fix Version/s STABLE backlog [ 10463 ]
        Labels patch patch triaged
        David Balch made changes -
        Attachment ims-navigation.patch [ 27122 ]
        David Balch made changes -
        Testing Instructions Load a IMS-CP package which includes items with no resource ("identifierref" attribute). View it.

        If the following are true, the fix worked:
         1. items without resources are non-linked plain text, and do not react when clicked
         2. The first item with a resource is displayed in the content area.
        Load a IMS-CP package which includes items with no resource ("identifierref" attribute). View it.

        If the following are true, the fix worked:
         1. The first item with a resource is displayed when the IMSCP is viewed.
         2. Items without resources are non-linked plain text.
         3. Clicking on an item without resources displays a list of child node titles in the content area.
         4. Clicking one of child nodes listed loads the corresponding item (with or without resource) in the in the content area.
        Michael de Raadt made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Assignee moodle.com [ moodle.com ]
        Resolution Won't Fix [ 2 ]
        Fix Version/s STABLE backlog [ 10463 ]

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: