Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31815

Periods in username fail email registration confirmation

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Authentication
    • Labels:
      None

      Description

      This problem was first noted here for past versions of moodle, but was closed as inactive/ resolved:

      http://tracker.moodle.org/browse/MDL-18745

      It seems to still be an issue with Moodle version 2.2

      "The email registration confirmation cannot proceed when there is an invalid character in the username.

      The signup page allows the username to be entered with in one or more trailing periods (and any name fields as well, not sure if that leads to other related problems)

      e.g. username1.

      The resulting email registration link in the confirmation email sent for newly added users does not work if the username ends in one or more periods. I'm assuming that the period is stripped because it was invalid.

      The moodle error message presented from confirm.php is "Invalid confirmation data"

      Since the username is used to create the confirmation email message, there should be validation on the username field prevent entry of invalid characters causing invalid email messages links being sent, which are unusable."

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            skodak Petr Skoda added a comment -

            I guess it should be enough to encode "." to "%2E" - testing...

            Show
            skodak Petr Skoda added a comment - I guess it should be enough to encode "." to "%2E" - testing...
            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report.

            Show
            skodak Petr Skoda added a comment - Thanks for the report.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (21, 22 & master)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 & master)
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Works Great

            Thanks for fixing this, Petr.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Works Great Thanks for fixing this, Petr.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            FCT (fixed, closing, thanks). Ciao

            "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
            ~ Benjamin Disraeli

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12