While looking into this I noticed the below in grade/report/grader/index.php

// Override perpage if set in URL

if ($perpageurl) {

    $report->user_prefs['studentsperpage'] = $perpageurl;

}

It doesn't work as there is nothing at $report->user_prefs and most likely hasn't worked since at least 2007 so I'm intending to remove it barring a good reason becoming apparent.

Adding a branch for peer review

Added testing instructions.

Hi Andrew,

The changes to add the page param look good.
As for the removing of the perpageurl it would be nice to clean that up entirely.
I see in index.php there is still an optional_param for perpage that is unused, and further down at the paging bar it is referring to the studentsperpage preference.
Btw is would it be easy to get that stuff working again?

Cheers
Sam

Ive removed that optional_param. Well spotted. The students per page preference is correct. That still exists (and works).

It would certainly be possible to reimplement the ability to override the students per page setting via a URL parameter. Its possible there is some value to it, generating a report you're going to print perhaps. First though, we need to clarify MDL-26275 as currently its easy to wind up with a grader report that contains more fields that PHP's max_input_vars resulting in much misery and gnashing of teeth Until we have that pinned down I'm wary of creating a three way conflict (the students per page preference, the students per page URL param and the max students per page we can show without reaching max_input_vars)

Thanks guys, this has been integrated into 22 and master.
This test story was a nice read, happy testing.

Ah Michael has spotted this is affecting 21 as well.
Thats been picked into 21 now too and gd for testing.

Test result: Success.

Tested in 2.1, 2.2 and master, with and without JS.

Congratulations are in order, you've made it, or at least your code has!
It's now part of Moodle and both the git and cvs repositories have been updated.

This issue is being marked as fixed and closed.

Thank you.