Moodle
  1. Moodle
  2. MDL-31822

Non-default Section name not shown at the site level

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.1, 2.6.1
    • Fix Version/s: STABLE backlog
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide
      1. Go to Admin > Front page > Front page settings
      2. tick 'include topic section'
      3. Go to top-level of a moodle site and log in as admin
      4. Turn editing on
      5. Edit summary for the front page
      6. Uncheck "Use default section name"
      7. Insert "My site title" into the "Section name" field, and Save changes
      8. Viewing the front page again, the text "My site title" should appear as a title at the top of the summary.
      Show
      Go to Admin > Front page > Front page settings tick 'include topic section' Go to top-level of a moodle site and log in as admin Turn editing on Edit summary for the front page Uncheck "Use default section name" Insert "My site title" into the "Section name" field, and Save changes Viewing the front page again, the text "My site title" should appear as a title at the top of the summary.
    • Workaround:
      Hide

      Apply attached patch

      Show
      Apply attached patch
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
    • Rank:
      38458

      Description

      Editing the Section summary for a Moodle site, unchecking "Use default section name", and adding a custom "Section name" [0], does not result in the Section name being displayed as a heading on the Site homepage.

      Action: Edited summary for the front page, enabling and adding a custom "Section name" value. Saved changes.

      Expected results: Custom "Section name" should appear as a title at the top of the summary.
      Actual results: No title is displayed.

      Patch to fix this attached.

      [0] http://docs.moodle.org/22/en/course/editsection

        Activity

        Hide
        Dan Poltawski added a comment -

        Thanks for the Patch, David! I've put it into a git branch here for review. I've tested it and it does as suggested.

        But I have question of whether this is the right solution to this problem. The front page is kind of special and perhaps it shouldn't have this setting available at all. I also noticed that conditional settings on topics show up on this section also. This probably doesn't make sense.

        Show
        Dan Poltawski added a comment - Thanks for the Patch, David! I've put it into a git branch here for review. I've tested it and it does as suggested. But I have question of whether this is the right solution to this problem. The front page is kind of special and perhaps it shouldn't have this setting available at all. I also noticed that conditional settings on topics show up on this section also. This probably doesn't make sense.
        Hide
        Dan Poltawski added a comment -

        Hi Sam,

        Whilst working on this issue I just noticed that the conditional settings are appearing the front page topic section.

        My thought is that we really shouldn't be showing these settings on the front page - just wondering if you agreed?

        (ps. Sorry for adding you as a watcher on so many issues in the past few days!)

        Show
        Dan Poltawski added a comment - Hi Sam, Whilst working on this issue I just noticed that the conditional settings are appearing the front page topic section. My thought is that we really shouldn't be showing these settings on the front page - just wondering if you agreed? (ps. Sorry for adding you as a watcher on so many issues in the past few days!)
        Hide
        David Balch added a comment -

        I have sites that use the front page section summary; it's a good place to introduce the site - e.g.: http://reciprocatesite.conted.ox.ac.uk/
        Taking that away would be annoying, as I'd likely have to add it back.

        Furthermore, having the section name in a separate field feels much better than including it in the text field.

        NB: The section summary is only visible when the front page setting "Include a topic" (numsections) is enabled (that confused me for a moment there).

        Show
        David Balch added a comment - I have sites that use the front page section summary; it's a good place to introduce the site - e.g.: http://reciprocatesite.conted.ox.ac.uk/ Taking that away would be annoying, as I'd likely have to add it back. Furthermore, having the section name in a separate field feels much better than including it in the text field. NB: The section summary is only visible when the front page setting "Include a topic" (numsections) is enabled (that confused me for a moment there).
        Hide
        Sam Marshall added a comment -

        Dan - You're saying there are conditional options for section 0? I agree, there shouldn't be. Are you going to fix it or do you want me to? (If the latter, file new issue please.)

        I hadn't noticed there were ANY section options for section 0 so that would explain why I missed it.

        Show
        Sam Marshall added a comment - Dan - You're saying there are conditional options for section 0? I agree, there shouldn't be. Are you going to fix it or do you want me to? (If the latter, file new issue please.) I hadn't noticed there were ANY section options for section 0 so that would explain why I missed it.
        Hide
        Dan Poltawski added a comment -

        Sam: i'll take it

        David: I'm not suggesting removing the summary, just the title part of it because it doesn't make the same sense as a section on another course page (used to refer to that section). And if you wanted a section-name like title you can just use html.

        Show
        Dan Poltawski added a comment - Sam: i'll take it David: I'm not suggesting removing the summary, just the title part of it because it doesn't make the same sense as a section on another course page (used to refer to that section). And if you wanted a section-name like title you can just use html.
        Hide
        David Balch added a comment -

        Dan: Ah, ok. I take it that the front page section name isn't used in the navigation at all then.
        I guess not having conditional options the front page section means amending it as a special case, so excluding the section name would fit in with that.

        There might be an argument for keeping it so that the UI is consistent with sections in courses, but obviously it's at your discretion

        Show
        David Balch added a comment - Dan: Ah, ok. I take it that the front page section name isn't used in the navigation at all then. I guess not having conditional options the front page section means amending it as a special case, so excluding the section name would fit in with that. There might be an argument for keeping it so that the UI is consistent with sections in courses, but obviously it's at your discretion
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Charles Fulton added a comment -

        This is still broken in 2.6.1.

        Show
        Charles Fulton added a comment - This is still broken in 2.6.1.

          People

          • Votes:
            5 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: