Moodle

Profile field "confirmed" set to 0 for roaming users created via mnet course enrolments

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.9.17, 2.1, 2.2
  • Fix Version/s: 1.9.19, 2.1.7, 2.2.4
  • Component/s: MNet
  • Labels:
    None

Description

Related to http://tracker.moodle.org/browse/MDL-27107 and http://tracker.moodle.org/browse/MDL-29991 (I can't reopen issues) the MDL-27107 and MDL-29991 patches only solves the problem when users are created into the remote host via login (auth/mnet), when users are created through the remote course enrolment process (enrol/mnet/enrol.php/enrol_user method) the users are created with 'confirmed' = 0

Steps to reproduce the problem:
1.- A Moodle 1.9 installation as identity provider publisher
2.- A Moodle 2.1 installation as identity provider subscriber
3.- On Moodle 1.9 go to frontpage administration block -> Networking -> Enrolments
4.- On Moodle 1.9 select the 2.1 subscriber host and enrol users (IMPORTANT: Users who doesn't exists in the 2.1 installation)

Result:
Users created on the Moodle 2.1 installation with the 'confirmed' field set to 0. If the Moodle 2.1 administration setting 'deleteunconfirmed' is enabled the cron will delete the no-confirmed users.

The reproduction steps are based on a real case, but watching both 1.9 and 2.x code I suspect that the problem is applicable to all branches

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Monllaó added a comment -

Pull branches rebased

Show
David Monllaó added a comment - Pull branches rebased
Hide
Permalink
David Mudrak added a comment -

Very well spotted and patched David! Submitting for integration.

Show
David Mudrak added a comment - Very well spotted and patched David! Submitting for integration.
Hide
Permalink
Dan Poltawski added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
David Monllaó added a comment -

Thanks Dan. Done

Show
David Monllaó added a comment - Thanks Dan. Done
Hide
Permalink
Sam Hemelryk added a comment -

Thanks David and David, this has been integrated now

Show
Sam Hemelryk added a comment - Thanks David and David, this has been integrated now
Hide
Permalink
Ankit Agarwal added a comment -

Thanks Sam and Apu for the help with testing
This works as expected.
Passing

Show
Ankit Agarwal added a comment - Thanks Sam and Apu for the help with testing This works as expected. Passing
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

Many thanks for your collaboration!

Ciao

Show
Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: