Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.7, 2.4
-
Fix Version/s: 2.4
-
Component/s: Calendar
-
Environment:MySQL, Windows Server 2003, PHP 5.3.8 (VC9), Apache 2.2.21.0 (VC9)
-
Database:MySQL
-
Testing Instructions:
-
Workaround:
-
Difficulty:Easy
-
Affected Branches:MOODLE_20_STABLE, MOODLE_24_STABLE
-
Fixed Branches:MOODLE_24_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-31824-master -
Pull Master Diff URL:
Description
When looking at calendar/view.php?view=month the HTML classes are inconsistent with other calendar views and are more generally speaking just broken:
- Day cells are rendered as "today" or "nottoday" to signify blank cells. By comparison other calendar views use "day" or "dayblank" and then use "today" to highlight the actual date today.
- When viewing a month other than the current month every day renders with a "nottoday" class.
Main problem appear to be caused by an if statement in calendar/renderer.php at around line 520:
// Special visual fx for today
|
if($display->thismonth && $calendar->day == $calendar->day) {
|
of course $calendar->day will ALWAYS equal itself so it returns every day of the current month as "today".
Attachments
Issue Links
- has been marked as being related by
-
MDL-36367 Calendar "month" view - HTML classes are inconsistent (Backport MDL-31824)
-
- Closed
-