Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31832

CLI upgrade does not check that Moodle actually needs upgrading

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.4, 2.2.1, 2.3
    • Fix Version/s: 2.1.5, 2.2.2
    • Component/s: Administration
    • Labels:
      None
    • Environment:
      CLI
    • Testing Instructions:
      Hide

      Testing difficulty: easy, requires CLI access

      1. Via the web, visit /admin site of your server and make sure that no upgrade process is triggered (that is, normal Admin notifications page appears)
      2. At the command line, execute /admin/cli/upgrade.php
      3. TEST: Make sure no upgrade process is triggered

      Show
      Testing difficulty: easy, requires CLI access 1. Via the web, visit /admin site of your server and make sure that no upgrade process is triggered (that is, normal Admin notifications page appears) 2. At the command line, execute /admin/cli/upgrade.php 3. TEST: Make sure no upgrade process is triggered
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31832-cli-upgrade
    • Pull Master Diff URL:

      Description

      Whenever you execute admin/cli/upgrade.php, a page like this appear:

      == Upgrading Moodle database from version 2.2.1+ (Build: 20120223) (2011120501.1) to 2.2.1+ (Build: 20120223) (2011120501.1) ==

      Your Moodle files have been changed, and you are about to automatically
      upgrade your server to this version:

      2.2.1+ (BUILD: 20120223) (2011120501.1)

      Once you do this you can not go back again.

      Please note that this process can take a long time.

      Are you sure you want to upgrade this server to this version?

      Note that both versions (builds) are identical and the text is actually a lie - the Moodle files have NOT changed. This is not a major problem as no upgrade step is really executed. But it's quite confusing.

        Attachments

          Activity

            People

            Assignee:
            mudrd8mz David Mudrák (@mudrd8mz)
            Reporter:
            mudrd8mz David Mudrák (@mudrd8mz)
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              12/Mar/12