Moodle

Recent conversations need an explicit link

Details

  • Testing Instructions:
    Hide

    For this test you'll need three users.

    Have all users send the other two at least one message.

    As any of the three users go to messaging and select "Recent conversations" from the messaging navigation. You should get a list of your recent conversations (the most recent message to or from each other user).

    Beneath each conversation is a link to that conversation. Clicking it should take you to the most recent messages between the two users.

    Show
    For this test you'll need three users. Have all users send the other two at least one message. As any of the three users go to messaging and select "Recent conversations" from the messaging navigation. You should get a list of your recent conversations (the most recent message to or from each other user). Beneath each conversation is a link to that conversation. Clicking it should take you to the most recent messages between the two users.
  • Affected Branches:
    MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-31835_recent_conversations
  • Pull Master Diff URL:

Description

This has bugged me for ages:

Can you please add a link under each recent conversations item that says "Read the full conversation". It would go to the same page as clicking on the user's name (which I think is just too un-intuitive to discover right now).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Davis added a comment -

Adding a branch containing a possible solution. It is formatted the way it is so that the context links for recent conversations will be the same as for recent notifications.

Also, I had it link to the full message history instead of just the recent messages. It felt odd clicking on 'view full conversation' then having to click 'full history' to actually get the full history.

Show
Andrew Davis added a comment - Adding a branch containing a possible solution. It is formatted the way it is so that the context links for recent conversations will be the same as for recent notifications. Also, I had it link to the full message history instead of just the recent messages. It felt odd clicking on 'view full conversation' then having to click 'full history' to actually get the full history.
Hide
Permalink
Martin Dougiamas added a comment - - edited

I suppose the link name could have been "View this conversation" instead. But if the full history page isn't too long then it's probably better anyway.

Show
Martin Dougiamas added a comment - - edited I suppose the link name could have been "View this conversation" instead. But if the full history page isn't too long then it's probably better anyway.
Hide
Permalink
Andrew Davis added a comment -

hrmmm, I may use that string and change the link. Not sure. I'm just worried that somewhere out there someone will accrue a history of zillions of messages between them and another user. Not sure how realistic that worry is.

Show
Andrew Davis added a comment - hrmmm, I may use that string and change the link. Not sure. I'm just worried that somewhere out there someone will accrue a history of zillions of messages between them and another user. Not sure how realistic that worry is.
Hide
Permalink
Jason Fowler added a comment -

Code looks good

Show
Jason Fowler added a comment - Code looks good
Hide
Permalink
Andrew Davis added a comment -

I did wind up deciding to go with the string you suggested Martin and having the link go to the last messages between the 2 users rather than a full history.

Branches added and testing instructions updated.

Show
Andrew Davis added a comment - I did wind up deciding to go with the string you suggested Martin and having the link go to the last messages between the 2 users rather than a full history. Branches added and testing instructions updated.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Andrew, this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now.
Hide
Permalink
Michael de Raadt added a comment -

Test result: Success.

Tested under 2.1, 2.2 and master.

Show
Michael de Raadt added a comment - Test result: Success. Tested under 2.1, 2.2 and master.
Hide
Permalink
Sam Hemelryk added a comment -

Congratulations are in order, you've made it, or at least your code has!
It's now part of Moodle and both the git and cvs repositories have been updated.

This issue is being marked as fixed and closed.

Thank you.

Show
Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: