Moodle
  1. Moodle
  2. MDL-31838

Cache static responses from repositories in file picker

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker, Repositories
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Use FilePicker to upload files
      2. make sure that when you switch between repositories, the "loading" process does not appear for Upload File repository (starting from the second time)
      3. try to upload files using filepicker and make sure it works

      Show
      1. Use FilePicker to upload files 2. make sure that when you switch between repositories, the "loading" process does not appear for Upload File repository (starting from the second time) 3. try to upload files using filepicker and make sure it works
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-31838-master
    • Rank:
      38479

      Description

      Allow repositories to notify file picker that their response can be cached.
      This is the case when in reply to 'list' command the repository sends a static search form. We don't need to request this form many times. Especially for file upload

        Activity

        Hide
        Dongsheng Cai added a comment -

        Looks good to me

        Show
        Dongsheng Cai added a comment - Looks good to me
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        cool, thats been integrated and is ready for testing..

        i can't think of any docs but if you can think of any docs that could mention this caching from this performance change, please feel free to doc it. especially since it will help repository developers to start caching in their plugins.

        Show
        Aparup Banerjee added a comment - cool, thats been integrated and is ready for testing.. i can't think of any docs but if you can think of any docs that could mention this caching from this performance change, please feel free to doc it. especially since it will help repository developers to start caching in their plugins.
        Hide
        Adrian Greeve added a comment -

        When moving from repositories such as youtube and wikimedia or uploading a file from the computer it doesn't show the loading screen once it's been loaded. Tested pre-patch to see the difference. The patch seems good.
        Thanks.

        Show
        Adrian Greeve added a comment - When moving from repositories such as youtube and wikimedia or uploading a file from the computer it doesn't show the loading screen once it's been loaded. Tested pre-patch to see the difference. The patch seems good. Thanks.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli
        Hide
        Marina Glancy added a comment -

        Removing dev_docs_required, the attribute 'allowcaching' is mentioned on http://docs.moodle.org/dev/Repository_plugins#get_listing.28.24path.3D.22.22.2C_.24page.3D.22.22.29

        Show
        Marina Glancy added a comment - Removing dev_docs_required, the attribute 'allowcaching' is mentioned on http://docs.moodle.org/dev/Repository_plugins#get_listing.28.24path.3D.22.22.2C_.24page.3D.22.22.29

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: