Moodle
  1. Moodle
  2. MDL-31841

Feedback in gradebook user view is centered

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Gradebook
    • Labels:
      None
    • Testing Instructions:
      Hide

      Check that the site settings grade_report_user_showfeedback and grade_report_showquickfeedback are turned on.

      Go to the grader report for a course with at least one student. Turn editing on and enter some feedback for a grade item.

      Go to the user report, select that student. The feedback should not be centred.

      Show
      Check that the site settings grade_report_user_showfeedback and grade_report_showquickfeedback are turned on. Go to the grader report for a course with at least one student. Turn editing on and enter some feedback for a grade item. Go to the user report, select that student. The feedback should not be centred.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31841_feedback_align
    • Rank:
      38483

      Description

      The Feedback displayed in the User View of the Gradebook is centered. It should be left-justfied. Although this is a very minor bug that does not affect functionality, our graphics design professor was finding it to be quite disturbing. It does affect readability.

      There was a Moodle Tracker entry for a similar issue in 2005/2006 - MDL-3383.

        Activity

        Hide
        Isuru Madushanka Weerarathna added a comment -

        Hi,

        I worked on this minor bug and I have attached a small patch for this.

        • Thanks
        Show
        Isuru Madushanka Weerarathna added a comment - Hi, I worked on this minor bug and I have attached a small patch for this. Thanks
        Hide
        Andrew Davis added a comment -

        Hello. Thankyou for the patch. I am putting up a slightly modified version for peer review.

        In future, if you are able supply code changes via git I can more easily commit your code in your name. That just means you can get full credit for the work you have done

        Show
        Andrew Davis added a comment - Hello. Thankyou for the patch. I am putting up a slightly modified version for peer review. In future, if you are able supply code changes via git I can more easily commit your code in your name. That just means you can get full credit for the work you have done
        Hide
        Dan Poltawski added a comment -

        Hi,

        All looks good apart from the underscores in variable name which are against the coding guidelines.

        Show
        Dan Poltawski added a comment - Hi, All looks good apart from the underscores in variable name which are against the coding guidelines.
        Hide
        Andrew Davis added a comment -

        Right you are. Ive fixed that up. Here is the relevant section of the coding guidelines for anyone interested. http://docs.moodle.org/dev/Coding_style#Variables

        Show
        Andrew Davis added a comment - Right you are. Ive fixed that up. Here is the relevant section of the coding guidelines for anyone interested. http://docs.moodle.org/dev/Coding_style#Variables
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks Andrew this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Andrew this has been integrated now
        Hide
        Tim Barker added a comment -

        Tested in 2.2 and 2.1 and the feedback was not centerd.

        Show
        Tim Barker added a comment - Tested in 2.2 and 2.1 and the feedback was not centerd.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: