Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.1
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Wiki (2.x)
    • Labels:
    • Rank:
      38493

      Description

      Wiki pages have a wiki search form. There is a whitespace character between the input field and the aearch button. This makes the layout of search forms inconsitent.

      The problem is in the file mod/wiki/lib.php line 486.

      $output .= ' <input value="' . get_string('searchwikis', 'wiki') . '" type="submit" />';

      This is the fixed line:

      $output .= '<input value="' . get_string('searchwikis', 'wiki') . '" type="submit" />';

        Activity

        Show
        Juho Viitasalo added a comment - I did this for a practise. https://github.com/jiv-e/moodle/commit/afbe3710a058ec0d327bd1a31a9fd54085425ad6
        Hide
        Juho Viitasalo added a comment -

        I wonder why this isn't fixed already?

        Show
        Juho Viitasalo added a comment - I wonder why this isn't fixed already?
        Hide
        Ankit Agarwal added a comment -

        Hi guys,
        The patch is good and ready to be integrated.

        Just the commit msg should be reworded to the standard format we use for commit msgs
        http://docs.moodle.org/dev/Commit_cheat_sheet

        I am sure integrators wont take in commits which doesn't contain MDL numbers.

        Thanks

        Show
        Ankit Agarwal added a comment - Hi guys, The patch is good and ready to be integrated. Just the commit msg should be reworded to the standard format we use for commit msgs http://docs.moodle.org/dev/Commit_cheat_sheet I am sure integrators wont take in commits which doesn't contain MDL numbers. Thanks
        Hide
        Charles Fulton added a comment -

        I've pulled Juho's branch into my repo and amended the commit plus rebased (clean).

        Show
        Charles Fulton added a comment - I've pulled Juho's branch into my repo and amended the commit plus rebased (clean).
        Hide
        Ankit Agarwal added a comment -

        Thanks Charles
        Sending this for integration.

        Show
        Ankit Agarwal added a comment - Thanks Charles Sending this for integration.
        Hide
        Ankit Agarwal added a comment -

        @integrators
        Can be cherry-picked to stables

        Show
        Ankit Agarwal added a comment - @integrators Can be cherry-picked to stables
        Hide
        Sam Hemelryk added a comment -

        Thanks, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks, this has been integrated now
        Hide
        Eloy Lafuente (stronk7) added a comment -

        U P S T R E A M I Z E D !

        Many thanks for the hard work, closing this as fixed.

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - U P S T R E A M I Z E D ! Many thanks for the hard work, closing this as fixed. Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: