Moodle
  1. Moodle
  2. MDL-31856

Responses are not displayed consistently after activity closes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Choice
    • Labels:
    • Testing Instructions:
      Hide

      -Create a choice activity with a close date, 'Publish results' set to 'Do not publish results to students', and 'Allow choice to be updated' set to 'Yes'.
      -Log in as a student and complete the choice activity.
      -As a student, view the choice after the close date. 'Your selection:' should be displayed.

      Show
      -Create a choice activity with a close date, 'Publish results' set to 'Do not publish results to students', and 'Allow choice to be updated' set to 'Yes'. -Log in as a student and complete the choice activity. -As a student, view the choice after the close date. 'Your selection:' should be displayed.
    • Workaround:
      Hide

      Set 'Allow choice to be updated' to No after the choice activity closes so that users can see their own selections.

      Show
      Set 'Allow choice to be updated' to No after the choice activity closes so that users can see their own selections.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-31856_choice_responses_inconsistently_displayed
    • Rank:
      38499

      Description

      After the choice activity closes, students are not shown their own selections if 'Allow choice to be updated' is set to Yes. If 'Allow choice to be updated' is set to No, students can see their selections.

      Whether or not a user can update his/her selection when the choice is open shouldn't affect what is displayed after the choice is closed.

        Activity

        Hide
        Kanika Goyal added a comment -

        Hi,
        Here is a small patch for -
        master - https://github.com/kanikagoyal/moodle/compare/master...master_MDL-31856_choice_responses_inconsistently_displayed

        MOODLE_22_STABLE - https://github.com/kanikagoyal/moodle/compare/MOODLE_22_STABLE...m22_MDL-31856_choice_responses_inconsistently_displayed

        This patch will display the choice selection after choice is closed for both 'Allow choice to be updated' set to Yes or No.

        Please do let me know if any changes are required.

        Show
        Kanika Goyal added a comment - Hi, Here is a small patch for - master - https://github.com/kanikagoyal/moodle/compare/master...master_MDL-31856_choice_responses_inconsistently_displayed MOODLE_22_STABLE - https://github.com/kanikagoyal/moodle/compare/MOODLE_22_STABLE...m22_MDL-31856_choice_responses_inconsistently_displayed This patch will display the choice selection after choice is closed for both 'Allow choice to be updated' set to Yes or No. Please do let me know if any changes are required.
        Hide
        Dan Marsden added a comment -

        looks good to me! - thanks, submitting for integration.

        Show
        Dan Marsden added a comment - looks good to me! - thanks, submitting for integration.
        Hide
        Kanika Goyal added a comment -

        Thanks Dan, for having a look and submitting it for integration

        Show
        Kanika Goyal added a comment - Thanks Dan, for having a look and submitting it for integration
        Hide
        Dan Poltawski added a comment -

        Thanks, this has been integrated now

        I also cherry-picked to MOODLE_21_STABLE

        Show
        Dan Poltawski added a comment - Thanks, this has been integrated now I also cherry-picked to MOODLE_21_STABLE
        Hide
        Rossiani Wijaya added a comment -

        This looks good.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This looks good. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has landed upstream, finally! Yay!

        תודה רבה && شكرا جزيلا



        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao
        Hide
        Kanika Goyal added a comment -

        Thanks all for closing this issue

        Kanika

        Show
        Kanika Goyal added a comment - Thanks all for closing this issue Kanika

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: