Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31872

Replace div tags with a tags in course sections right side

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.2.1
    • Fix Version/s: None
    • Component/s: Course
    • Labels:

      Description

      Without javascript the course sections right side links are in <a> tags. When javascript is turned on, some of the links are removed and some are replaced with <div> tags. This makes theming harder and is inconsistent. I have added an image in the attachments.

        Gliffy Diagrams

          Activity

          Show
          juonio Juho Viitasalo added a comment - Here is the fix: https://github.com/jiv-e/moodle/commit/50e8225899aa48061859481195cc81d7b42324fb
          Hide
          juonio Juho Viitasalo added a comment - - edited

          The point is that if we consider these as links they should all be in <a> tags.

          Show
          juonio Juho Viitasalo added a comment - - edited The point is that if we consider these as links they should all be in <a> tags.
          Hide
          salvetore Michael de Raadt added a comment -

          Thanks for raising this and providing a patch.

          This has been resolved in more recent versions. I'll leave this issue here with its patch in case others wish to make use of it.

          Show
          salvetore Michael de Raadt added a comment - Thanks for raising this and providing a patch. This has been resolved in more recent versions. I'll leave this issue here with its patch in case others wish to make use of it.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: