Moodle
  1. Moodle
  2. MDL-31889

Numerical amswers are graded as good independetly of the decsep used

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.2.1
    • Fix Version/s: STABLE backlog
    • Component/s: Questions
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      38535

      Description

      You create a numerical question in french language using , as decsep and you use it in a frech language environment.
      the grade is the same with 23,8 or 23.8 as response.
      you answer the same question in english as language you get full grade in either case.
      however the good response is shown with, or. following your language.

      As long as we don't have specific grading for decsep used I agree with no penlty for decsep.
      However the correct response display should follow.

      This has been tested on actual moodle demo site.
      Moodle 2.2.1 (Build: 20120109)

      I am setting this a a bug so we can discuss what exactly we want for numerical question grading and decsep.

        Issue Links

          Activity

          Hide
          Pierre Pichet added a comment -

          I will test again tomorrow in case I miss something...

          Show
          Pierre Pichet added a comment - I will test again tomorrow in case I miss something...
          Hide
          Pierre Pichet added a comment -

          Just to illustrate the case using french and english setting.

          More to explore i.e. with language that use . as thousands separator.

          Show
          Pierre Pichet added a comment - Just to illustrate the case using french and english setting. More to explore i.e. with language that use . as thousands separator.
          Hide
          Pierre Pichet added a comment -

          This handling of decsep is related to the choices done when completing 2,1
          see MDL-27418
          /**

          • This method can be used for more locale-strict parsing of repsonses. At the
          • moment we don't use it, and instead use the more lax parsing in apply_units.
          • This is just a note that this funciton was used in the past, so if you are
            ...
            protected function parse_response($response)

          The apply_units() function will modify unique , to a . so that 3,4 will become 3.4 and
          be valid as PHP will recongnize it as 3.4.
          This apply_units() is used in numerical rendering but was not implemented in the multianswer rendering.MDL-28238

          The validation string when , is used in an english language setting needs to be improved.

          The equal grading for , or . as decsep if they are correctly identify should remain a feature until we introduce full decsep grading.
          Let's see first how the question editing interface will improve in 2,3 .

          Show
          Pierre Pichet added a comment - This handling of decsep is related to the choices done when completing 2,1 see MDL-27418 /** This method can be used for more locale-strict parsing of repsonses. At the moment we don't use it, and instead use the more lax parsing in apply_units. This is just a note that this funciton was used in the past, so if you are ... protected function parse_response($response) The apply_units() function will modify unique , to a . so that 3,4 will become 3.4 and be valid as PHP will recongnize it as 3.4. This apply_units() is used in numerical rendering but was not implemented in the multianswer rendering. MDL-28238 The validation string when , is used in an english language setting needs to be improved. The equal grading for , or . as decsep if they are correctly identify should remain a feature until we introduce full decsep grading. Let's see first how the question editing interface will improve in 2,3 .
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this issue.

          We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

          If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

          Michael d.

          TW9vZGxlDQo=

          Show
          Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
          Hide
          Pierre Pichet added a comment -

          This is still relevant so should not be closed

          Show
          Pierre Pichet added a comment - This is still relevant so should not be closed

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: