Moodle
  1. Moodle
  2. MDL-31894

get_course_context excepts context and not boolean in 2.1

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.1.4
        • Fix Version/s: 2.1.5
        • Component/s: Blocks
        • Labels:
          None
        • Testing Instructions:
          Hide
          1. add people's block to forum module.
          2. click on participants link in block. should have no context errors.
          3. add peoples block on course and front page
          4. bump up the version number
          5. upgrade site and make sure no error is thrown.
          Show
          add people's block to forum module. click on participants link in block. should have no context errors. add peoples block on course and front page bump up the version number upgrade site and make sure no error is thrown.
        • Affected Branches:
          MOODLE_21_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE
        • Pull from Repository:
        • Rank:
          38540

          Description

          While fixing MDL-29274, wrong patch was applied on 2.1
          In 2.1 get_course_context excepts context and not boolean

            Issue Links

            is a regression caused by

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29274 People block returns wrong context to user/index.php if block added to module

            • Critical - Crashes server, loss of data, severe memory leak
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Ankit Agarwal added a comment -

              Hi Raj,
              Looks good now after the changes.
              Thanks

              Show
              Ankit Agarwal added a comment - Hi Raj, Looks good now after the changes. Thanks
              Hide
              Permalink
              Rajesh Taneja added a comment -

              Increaring the priority as regression is on stable branch.

              Show
              Rajesh Taneja added a comment - Increaring the priority as regression is on stable branch.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Integrated (21 only), thanks!

              Show
              Eloy Lafuente (stronk7) added a comment - Integrated (21 only), thanks!
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Tested the participants block on frontpage, coursecat page, coursepage and modulepage, with the patch no-one returns error. So passing!

              Show
              Eloy Lafuente (stronk7) added a comment - Tested the participants block on frontpage, coursecat page, coursepage and modulepage, with the patch no-one returns error. So passing!
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!).

              icao_reverse('arreis olik rebemevon afla letoh ognat');

              Closing, ciao

              Show
              Eloy Lafuente (stronk7) added a comment - Your changes are now upstream and will be included in the next minor released scheduled for March 13th (next Monday!). icao_reverse('arreis olik rebemevon afla letoh ognat'); Closing, ciao

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: