Moodle
  1. Moodle
  2. MDL-31901

Changing interface of file picker/manager/browser, use renderers

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: DEV backlog
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      As much as possible actions need to be tested in Filepicker:

      Please enable as many repositories as possible.

      Try the following actions:

      Navigating between repositories,
      switching between different view modes,
      navigating inside the folders
      navigating to second page, etc (when applicable)
      uploading files (changing it's attributes)
      selecting file - as is, changing the name
      selecting the file with the name that already exists and checking different actions - overwrite, rename, cancel
      try quickly select different links without waiting for the end of loading process
      when search box appears for the repository, test how it works
      try all action links such as 'Refresh', 'Manage', etc.

      FileManager:
      Create File or Folder resource or manage Private files.
      again - do as many actions as possible in all view modes:

      • rename, move files and folders, set main file, change license and author
      • create folders, navigate between folders
      • add files using filepicker
      • delete files and folders
      • drag and drop files to the filemanager (not all browsers support it)
      Show
      As much as possible actions need to be tested in Filepicker: Please enable as many repositories as possible. Try the following actions: Navigating between repositories, switching between different view modes, navigating inside the folders navigating to second page, etc (when applicable) uploading files (changing it's attributes) selecting file - as is, changing the name selecting the file with the name that already exists and checking different actions - overwrite, rename, cancel try quickly select different links without waiting for the end of loading process when search box appears for the repository, test how it works try all action links such as 'Refresh', 'Manage', etc. FileManager: Create File or Folder resource or manage Private files. again - do as many actions as possible in all view modes: rename, move files and folders, set main file, change license and author create folders, navigate between folders add files using filepicker delete files and folders drag and drop files to the filemanager (not all browsers support it)
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-files23
    • Rank:
      38548

      Description

      New design shall be applied to file picker, file manager and file browser.

      They need to use renderer, which provides templates to be used in both Javascript and non-javascript mode.

      Also screen reader accessibility shall be considered as much as possible.

        Issue Links

          Activity

          Hide
          Marina Glancy added a comment -

          This branch also has fixes for issues MDL-32083, MDL-14636, MDL-32473, MDL-32471.
          Barbara still continues to work on design

          Show
          Marina Glancy added a comment - This branch also has fixes for issues MDL-32083 , MDL-14636 , MDL-32473 , MDL-32471 . Barbara still continues to work on design
          Hide
          David Mudrak added a comment -

          I have thumbnails almost working in the filepicker. But while the plain list view displays icons. the tree-like view displays icons first and then replaces them with the standard mimetype icon. If i reload and expand nodes again manually, icons are kept. But then, collapsing and expanding other folders in the tree makes realicons replaced with mimetype icons again. To be checked after my work is merged.

          Show
          David Mudrak added a comment - I have thumbnails almost working in the filepicker. But while the plain list view displays icons. the tree-like view displays icons first and then replaces them with the standard mimetype icon. If i reload and expand nodes again manually, icons are kept. But then, collapsing and expanding other folders in the tree makes realicons replaced with mimetype icons again. To be checked after my work is merged.
          Hide
          Tim Barker added a comment -

          When I add photos to the HTML editor, under certain circumstances I can permanently break the HTML editor field.

          Test:
          1) Click insert/edit image in the html editor.
          2) Click Find or upload an image.
          3) In file picker click on an image then click select this file.
          4) Repeat steps 2 and 3.
          5) Click insert.

          Expected result:

          • Image will be inserted.
            Actual result:
          • Image is not inserted and it is impossible to add an image to the field ever again.

          I've demoed this to Marina and Donsheng already hence the lack of detail in these comments. Marina requested that I add this here rather than adding a new tracker item.

          Show
          Tim Barker added a comment - When I add photos to the HTML editor, under certain circumstances I can permanently break the HTML editor field. Test: 1) Click insert/edit image in the html editor. 2) Click Find or upload an image. 3) In file picker click on an image then click select this file. 4) Repeat steps 2 and 3. 5) Click insert. Expected result: Image will be inserted. Actual result: Image is not inserted and it is impossible to add an image to the field ever again. I've demoed this to Marina and Donsheng already hence the lack of detail in these comments. Marina requested that I add this here rather than adding a new tracker item.
          Hide
          Marina Glancy added a comment -

          Tim, that was my fault, I forgot 'overwrite-rename' dialogue in case of picking file from repositories. Fixed that in the branch

          Show
          Marina Glancy added a comment - Tim, that was my fault, I forgot 'overwrite-rename' dialogue in case of picking file from repositories. Fixed that in the branch
          Hide
          Pierre Pichet added a comment -

          When doing the commit last, unfortunately one call to form_filemanager_render() remained in questiont/type/essay/renderer.php moodle code at last on last master release.

          Tim Hunt is somewhere in the mountains.

          I will appreciate any suggestions on how to solve MDL-33356

          Show
          Pierre Pichet added a comment - When doing the commit last, unfortunately one call to form_filemanager_render() remained in questiont/type/essay/renderer.php moodle code at last on last master release. Tim Hunt is somewhere in the mountains. I will appreciate any suggestions on how to solve MDL-33356
          Hide
          Davo Smith added a comment -

          The commit 906e7d on 26th April 2012 has managed to remove the 'maximum attachments' text above the filemanager, introduced in commit adce02 on 23rd Feb 2012

          Show
          Davo Smith added a comment - The commit 906e7d on 26th April 2012 has managed to remove the 'maximum attachments' text above the filemanager, introduced in commit adce02 on 23rd Feb 2012

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: