Moodle
  1. Moodle
  2. MDL-31908

Glossary 'entry list' format: printable version does not show content

        Details

        • Testing Instructions:
          Hide

          1. Create glossary with 'Entry list' format (other options default).
          2. Add entry with title and description (other options default).
          3. Click the printer icon to go to the printable version.

          EXPECTED: The entry with title and description should be displayed so that it can be printed.

          ACTUAL: The entry title only is displayed, with no description.

          Show
          1. Create glossary with 'Entry list' format (other options default). 2. Add entry with title and description (other options default). 3. Click the printer icon to go to the printable version. EXPECTED: The entry with title and description should be displayed so that it can be printed. ACTUAL: The entry title only is displayed, with no description.
        • Affected Branches:
          MOODLE_21_STABLE
        • Fixed Branches:
          MOODLE_21_STABLE, MOODLE_22_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          master_MDL-31908_glossary_entrylist_print_version_not_showing_content
        • Pull Master Diff URL:
        • Rank:
          38557

          Description

          If you use 'entry list' format, the printable version of the glossary only contains the titles of each entry. This is not very useful when printing.

            Issue Links

            testing discovered

            Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32325 Glossary entry printing is not XHTML compliant and does not permit theming

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Kanika Goyal added a comment -

              While reproducing this issue, I found that on clicking the printer icon its not the printable version is not shown - the reason was - in /mod/glossary/print.php one extra parameter was being passed to function glossary_print_entry defined in /mod/glossary/lib.php.

              Patch for this issue-
              https://github.com/kanikagoyal/moodle/compare/master...master_MDL-31908_glossary_entrylist_print_version_not_showing_content

              Thanks,
              Kanika

              Show
              Kanika Goyal added a comment - While reproducing this issue, I found that on clicking the printer icon its not the printable version is not shown - the reason was - in /mod/glossary/print.php one extra parameter was being passed to function glossary_print_entry defined in /mod/glossary/lib.php. Patch for this issue- https://github.com/kanikagoyal/moodle/compare/master...master_MDL-31908_glossary_entrylist_print_version_not_showing_content Thanks, Kanika
              Hide
              Permalink
              Dan Marsden added a comment -

              good spotting - passing this up for peer review - thanks!

              Show
              Dan Marsden added a comment - good spotting - passing this up for peer review - thanks!
              Hide
              Permalink
              Dan Poltawski added a comment -

              Looks good to me, please submit for integration

              thanks!

              Show
              Dan Poltawski added a comment - Looks good to me, please submit for integration thanks!
              Hide
              Permalink
              Michael de Raadt added a comment -

              Hi, Dans.

              I've just triaged this, but it looks like it's ready to go up.

              Show
              Michael de Raadt added a comment - Hi, Dans. I've just triaged this, but it looks like it's ready to go up.
              Hide
              Permalink
              Dan Marsden added a comment -

              NOTE TO INTEGRATOR: please cherry-pick onto stable releases

              Show
              Dan Marsden added a comment - NOTE TO INTEGRATOR: please cherry-pick onto stable releases
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks guys this has been integrated now

              Show
              Sam Hemelryk added a comment - Thanks guys this has been integrated now
              Hide
              Permalink
              Michael de Raadt added a comment -

              Test result: Success

              Tested in 2.1, 2.2 and master.

              It's not pretty, but it works.

              I've launched another issue regarding the XHTML standards compliance and themability of the output.

              Show
              Michael de Raadt added a comment - Test result: Success Tested in 2.1, 2.2 and master. It's not pretty, but it works. I've launched another issue regarding the XHTML standards compliance and themability of the output.
              Hide
              Permalink
              Aparup Banerjee added a comment -

              The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

              Closing, have a good weekend!

              Show
              Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: