Moodle

Backport TinyMCE 3.4.9 to 22 stable

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.4, 2.2.1
  • Fix Version/s: 2.2.3
  • Component/s: HTML Editor
  • Labels:
    None
  • Testing Instructions:
    Hide

    pasted from MDL-30636:

    1/ test tinymce in moodle
    2/ test file picker integration - both files and links
    3/ concentrate on Moodle specific plugins - dragmath, moodlemotions, moodlenolink, moodlemedia, spellchecker

    Show
    pasted from MDL-30636 : 1/ test tinymce in moodle 2/ test file picker integration - both files and links 3/ concentrate on Moodle specific plugins - dragmath, moodlemotions, moodlenolink, moodlemedia, spellchecker
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE
  • Pull from Repository:

Description

By MDL-30636, TinyMCE 3.4.9 was upgraded into master (2.3).

This is about to backport it both to 22 (now using 3.4.6) and 21 (now using 3.4.2) stables (together and with 1w separation) once it's probed to be working ok on master.

Ciao

Issue Links

has a non-specific relationship to

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32141 outdated TinyMCE in 2.1.x does not work in Firefox 11

  • Critical - Crashes server, loss of data, severe memory leak
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-30636 Upgrade to TinyMCE 3.4.9

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

To integrators:
1/ 2.1 already diverged too much and the new editor can not be easily backported there, there is no technical reason to not upgrade from 2.1 to 2.2 so I decided to not spend more time on backporting

2/ the MDL in commit messages links MDL-30636, I guess it is better that way

Show
Petr Škoda added a comment - To integrators: 1/ 2.1 already diverged too much and the new editor can not be easily backported there, there is no technical reason to not upgrade from 2.1 to 2.2 so I decided to not spend more time on backporting 2/ the MDL in commit messages links MDL-30636 , I guess it is better that way
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

1/ oki, under you responsibility
2/ oki, you are laaaazzzzzyyyy eh? :-P

Looking to this. Ciao

Show
Eloy Lafuente (stronk7) added a comment - 1/ oki, under you responsibility 2/ oki, you are laaaazzzzzyyyy eh? :-P Looking to this. Ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Tidying issue title as far as we are going to backport only to 22.

Show
Eloy Lafuente (stronk7) added a comment - Tidying issue title as far as we are going to backport only to 22.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks! (22 only)

Side comment: Is https://github.com/moodle/custom-tinymce missing the 22_STABLE_3.4.9 ?

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (22 only) Side comment: Is https://github.com/moodle/custom-tinymce missing the 22_STABLE_3.4.9 ? Ciao
Hide
Permalink
Petr Škoda added a comment -

yes, I did not create a new branch for custom-tinymce because I backported stuff from master (keeping the original MDL).

Show
Petr Škoda added a comment - yes, I did not create a new branch for custom-tinymce because I backported stuff from master (keeping the original MDL).
Hide
Permalink
Sam Hemelryk added a comment -

Thanks guys, tested thoroughly and passed

Show
Sam Hemelryk added a comment - Thanks guys, tested thoroughly and passed
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

FCT (fixed, closing, thanks). Ciao

"I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
~ Benjamin Disraeli

Show
Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: