Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31917

Assignment submission grading interface is not intuitive when item has been graded via gradebook

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Assignment (2.2)
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide
      1. Create assignment activity
      2. As a student submit assignment
      3. Open Submitted Assignments View (within assignment)
      4. The Status button against the user who submitted assignment should read 'Grade'
      5. Open gradebook and grade submitted item there
      6. Open Submitted Assignments View (within assignment)
      7. The Status button against the user who submitted assignment should read 'View' as grading from assignment is no longer possible.
      Show
      Create assignment activity As a student submit assignment Open Submitted Assignments View (within assignment) The Status button against the user who submitted assignment should read 'Grade' Open gradebook and grade submitted item there Open Submitted Assignments View (within assignment) The Status button against the user who submitted assignment should read 'View' as grading from assignment is no longer possible.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31917-master-1

      Description

      When submissions are shown in the list via Submitted Assignments View (mod/assignment/submissions.php), the Status field will read 'Grade' even when the submission have already been graded via gradebook. In addition to that, neither 'Grade' nor 'Update' is possible on the opening page if item has been graded in the gradebook already. The reasonable solution is to display 'View' when submission has been graded/overridden/locked in the gradebook.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              kabalin Ruslan Kabalin added a comment -

              Can be cleanly cherry picked to older 2.x branches

              Show
              kabalin Ruslan Kabalin added a comment - Can be cleanly cherry picked to older 2.x branches
              Hide
              poltawski Dan Poltawski added a comment -

              Awaiting comments from Petr on linked bug -

              Show
              poltawski Dan Poltawski added a comment - Awaiting comments from Petr on linked bug -
              Hide
              poltawski Dan Poltawski added a comment -

              Looks good

              Show
              poltawski Dan Poltawski added a comment - Looks good
              Hide
              kabalin Ruslan Kabalin added a comment -

              Can be cleanly cherry-picked to 2.x stable branches.

              Show
              kabalin Ruslan Kabalin added a comment - Can be cleanly cherry-picked to 2.x stable branches.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Some hours ago...

              the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Ruslan, its been integrated now

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Ruslan, its been integrated now
              Hide
              salvetore Michael de Raadt added a comment -

              Test result: Success.

              Nicely done. Tested across 2.1, 2.2 and master.

              Show
              salvetore Michael de Raadt added a comment - Test result: Success. Nicely done. Tested across 2.1, 2.2 and master.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              FCT (fixed, closing, thanks). Ciao

              "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
              ~ Benjamin Disraeli

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/12