Moodle
  1. Moodle
  2. MDL-31919

Assignment is not listed as graded if grading has been done via gradebook

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Assignment (2.2), Course
    • Labels:
      None
    • Database:
      Any
    • Testing Instructions:
      Hide

      To replicate the issue:

      1. Create an assignment
      2. From user account submit something
      3. From user account make sure that you have Course overview block on /my/ page
      4. From user account on /my/ page check that assignment is not graded yet in the Course overview block
      5. From admin account open grade-book (grader report) and grade submitted work
      6. From user account on /my/ page check that assignment is still marked as non-graded in the Course overview block
      Show
      To replicate the issue: Create an assignment From user account submit something From user account make sure that you have Course overview block on /my/ page From user account on /my/ page check that assignment is not graded yet in the Course overview block From admin account open grade-book (grader report) and grade submitted work From user account on /my/ page check that assignment is still marked as non-graded in the Course overview block
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-31919-master-2
    • Rank:
      38569

      Description

      In some places that use assignment_print_overview function, like Course Overview Block, the assignment is not listed as graded if grading has been done in gradebook only.

        Issue Links

          Activity

          Hide
          Ruslan Kabalin added a comment -

          Can be cleanly cherry-picked to older 2.xbranches

          Show
          Ruslan Kabalin added a comment - Can be cleanly cherry-picked to older 2.xbranches
          Hide
          Dan Poltawski added a comment -

          Hi Petr - I was just wondering if you could comment on this - I think there might be more to it as I seem to remember the gradebook/assignment integration was an outstanding problem and I am not sure if it is as simple as suggested fix.

          Ruslan: FYI there is a new assignment module being targeted in for 2.3, you may find it more beneficial to focus your efforts looking and helping with that meeting your needs, there is work in progress code in MDL-31270

          Show
          Dan Poltawski added a comment - Hi Petr - I was just wondering if you could comment on this - I think there might be more to it as I seem to remember the gradebook/assignment integration was an outstanding problem and I am not sure if it is as simple as suggested fix. Ruslan: FYI there is a new assignment module being targeted in for 2.3, you may find it more beneficial to focus your efforts looking and helping with that meeting your needs, there is work in progress code in MDL-31270
          Hide
          Petr Škoda added a comment -

          Hi, the new assignment seems to be going in opposite direction than I proposed (I mean the grading part). I think the patch above makes sense for current stable branches. Ciao

          Show
          Petr Škoda added a comment - Hi, the new assignment seems to be going in opposite direction than I proposed (I mean the grading part). I think the patch above makes sense for current stable branches. Ciao
          Hide
          Dan Poltawski added a comment -

          Looks good then - please submit!

          Show
          Dan Poltawski added a comment - Looks good then - please submit!
          Hide
          Ruslan Kabalin added a comment -

          Can be cleanly cherry-picked to 2.x stable branches.

          Show
          Ruslan Kabalin added a comment - Can be cleanly cherry-picked to 2.x stable branches.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some hours ago...

          the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Sam Hemelryk added a comment -

          Thanks Ruslan, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Ruslan, this has been integrated now
          Hide
          Adrian Greeve added a comment -

          After getting around the issue that we had with assignments, I managed to test this and it's working fine.
          Thanks.

          Show
          Adrian Greeve added a comment - After getting around the issue that we had with assignments, I managed to test this and it's working fine. Thanks.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FCT (fixed, closing, thanks). Ciao

          "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
          ~ Benjamin Disraeli

          Show
          Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: