Moodle

Repositories wikimedia and youtube lack paging

Details

  • Testing Instructions:
    Hide

    1. Enable repositories wikimedia and youtube
    2. Open any text editor and insert media from youtube, make sure that search and pagination work
    3. Open any text editor and insert image from wikimedia, make sure that search and pagination work
    4. repeat 2 and 3 with Javascript disabled, make sure everything works. Please note, that the pagination without JS is not absolutely correct (page #1 does not work), there is a separate issue for that

    Show
    1. Enable repositories wikimedia and youtube 2. Open any text editor and insert media from youtube, make sure that search and pagination work 3. Open any text editor and insert image from wikimedia, make sure that search and pagination work 4. repeat 2 and 3 with Javascript disabled, make sure everything works. Please note, that the pagination without JS is not absolutely correct (page #1 does not work), there is a separate issue for that
  • Affected Branches:
    MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-31929-master
  • Pull Master Diff URL:

Description

repositories wikimedia and youtube:

  • save last search in $SESSION
  • process parameter 'page'
  • remove buttons 'Refresh', 'Search' and 'Logout' since they don't have meaning
    filepicker:
  • allow unknown number of pages ($data['pages'] = -1), show one 'Next' page after the current (both JS and non-JS modes)
    repository wikimedia:
  • add non-AJAX search form to make it work with JS disabled

Issue Links

has been marked as being related by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32036 Repositories wikimedia and youtube lack paging (backport)

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Improvement - An enhancement to an existing Moodle feature. MDL-32038 Textarea form element without JS

  • Minor - Minor loss of function where workaround is possible
  • Open - The issue is open and ready for the assignee to start work on it.
testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32037 Accidentally picking the wrong repository will disable it from working.

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dongsheng Cai added a comment -

Looks good, thanks

Show
Dongsheng Cai added a comment - Looks good, thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Some hours ago...

the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment - - edited

Integrated, thanks! (master only).

I've added one small extra commits adding some missing semicolons (optional).

Finally, just guessing if this could be considered for backporting, because can be considered a bug. For your consideration, discuss it there and proceed.

Ciao

PS: yay, 3 "considerations" in one phrase, amazing. I'm improving my skills! (sorry)

Show
Eloy Lafuente (stronk7) added a comment - - edited Integrated, thanks! (master only). I've added one small extra commits adding some missing semicolons (optional). Finally, just guessing if this could be considered for backporting, because can be considered a bug. For your consideration, discuss it there and proceed. Ciao PS: yay, 3 "considerations" in one phrase, amazing. I'm improving my skills! (sorry)
Hide
Permalink
Adrian Greeve added a comment -

I tested this out in master and the paging works well. I had a talk with Marina about javascript being diabled and there is an issue open for fixing that (MDL-32038).
Thanks.

Show
Adrian Greeve added a comment - I tested this out in master and the paging works well. I had a talk with Marina about javascript being diabled and there is an issue open for fixing that ( MDL-32038 ). Thanks.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

FCT (fixed, closing, thanks). Ciao

"I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
~ Benjamin Disraeli

Show
Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: