Moodle

Unread forum posts are NOT being highlighted in CORE themes

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2, 2.3
  • Fix Version/s: 2.2.6, 2.3.3
  • Component/s: Themes
  • Labels:
  • Testing Instructions:
    Hide

    Prior to Testing:

    • Make sure Theme Designer Mode is enabled in Theme settings.
    • Make sure 'Track unread forum posts' is enabled in your profile.

    When TESTING:

    1. TEST all CORE themes to see that forum posts are:
      • highlighted when in 'page-mod-forum-view' (unread coloumn 'forum post number' & 'tick' should have a pale-yellow background colour).
      • highlighted when selected (each unread forum post header row should have a pale-yellow background colour).
    Show
    Prior to Testing: Make sure Theme Designer Mode is enabled in Theme settings. Make sure 'Track unread forum posts' is enabled in your profile. When TESTING: TEST all CORE themes to see that forum posts are: highlighted when in 'page-mod-forum-view' (unread coloumn 'forum post number' & 'tick' should have a pale-yellow background colour). highlighted when selected (each unread forum post header row should have a pale-yellow background colour).
  • Affected Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-31934_master
  • Pull Master Diff URL:

Description

A meta issue to look for unread forum post highlighting problems in standard themes.

Issue Links

testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-36306 some core themes need CSS adjustments when highlighting unread forumpost

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Hi, Mary.

Are you planning to add more sub-tasks to this one, perhaps for more themes?

I'm just wondering if I should triage this issue or close it.

Show
Michael de Raadt added a comment - Hi, Mary. Are you planning to add more sub-tasks to this one, perhaps for more themes? I'm just wondering if I should triage this issue or close it.
Hide
Permalink
Mary Evans added a comment -

I think my original idea was to fix other themes, but have not looked to see if there are any! As I have not assigned myself to this...it might as well be closed.
Thanks
Mary

Show
Mary Evans added a comment - I think my original idea was to fix other themes, but have not looked to see if there are any! As I have not assigned myself to this...it might as well be closed. Thanks Mary
Hide
Permalink
Mary Evans added a comment -

@Michael,
I have just read a comment by Rosie in the sub-task fix for Formal White, where she mentions that there are other themes with the same problem. So I have reopened this with a view to checking and fixing all themes where necessary.

So in the circumstances it may be better to Triage this. Thanks
Mary

Show
Mary Evans added a comment - @Michael, I have just read a comment by Rosie in the sub-task fix for Formal White, where she mentions that there are other themes with the same problem. So I have reopened this with a view to checking and fixing all themes where necessary. So in the circumstances it may be better to Triage this. Thanks Mary
Hide
Permalink
Michael de Raadt added a comment -

Hi, Mary.

Thanks for continuing to work on this. I'll leave it in your capable hands.

Show
Michael de Raadt added a comment - Hi, Mary. Thanks for continuing to work on this. I'll leave it in your capable hands.
Hide
Permalink
Sam Hemelryk added a comment -

Hi Mary,

Changes look spot on, there is just one thing however.
These changes should probably be put in mod/forum/styles.css as they relate directly to the forum module.
I'll leave this in review at the moment, could you please move them there? Once done I'll integrate.
If you don't have time no probs just let me know and I'll find 5 min to do it myself (right at the end of my day here sorry otherwise I'd do it now).

Many thanks
Sam

Show
Sam Hemelryk added a comment - Hi Mary, Changes look spot on, there is just one thing however. These changes should probably be put in mod/forum/styles.css as they relate directly to the forum module. I'll leave this in review at the moment, could you please move them there? Once done I'll integrate. If you don't have time no probs just let me know and I'll find 5 min to do it myself (right at the end of my day here sorry otherwise I'd do it now). Many thanks Sam
Hide
Permalink
Mary Evans added a comment -

All done!

Show
Mary Evans added a comment - All done!
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Mary, has been integrated now

Show
Sam Hemelryk added a comment - Thanks Mary, has been integrated now
Hide
Permalink
Frédéric Massart added a comment -

Test passed on 2.2, 2.3 and master. Please just note that some of the themes should be updated to handle the post header background a little bit better.

Show
Frédéric Massart added a comment - Test passed on 2.2, 2.3 and master. Please just note that some of the themes should be updated to handle the post header background a little bit better.
Hide
Permalink
Mary Evans added a comment -

Thanks Fred,
I noticed that some themes did not work as well as others. I'll take a look and see what I can do.

Show
Mary Evans added a comment - Thanks Fred, I noticed that some themes did not work as well as others. I'll take a look and see what I can do.
Hide
Permalink
Dan Poltawski added a comment -

Hurray!

You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

Show
Dan Poltawski added a comment - Hurray! You did it, congratulations! You have on Mojito credit to redeem after the release of Moodle 2.4

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: