Moodle
  1. Moodle
  2. MDL-31935

Course search restore link is broken

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Backup, Global search
    • Labels:
    • Testing Instructions:
      Hide

      Search for a course
      Click 'Turn editing on' (if not already on)
      Click on the 'restore' icon beside one of the search results
      Check the 'restore course' page appears as expected

      Show
      Search for a course Click 'Turn editing on' (if not already on) Click on the 'restore' icon beside one of the search results Check the 'restore course' page appears as expected
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31935_search_restore_link
    • Rank:
      38586

      Description

      If you search for a course, then turn editing on, then click on the 'restore' icon, then you are taken to a page:

      '../files/index.php?id=[courseid]&wdir=/backupdata'

      This appears to be left over from Moodle 1.9

      The correct path would be:
      '[webroot]/backup/restorefile.php?contextid=[coursecontextid]'

      I'll attach a patch

        Activity

        Hide
        Davo Smith added a comment -

        I've added a patch for master, but it should cherry-pick cleanly onto the other branches.

        Show
        Davo Smith added a comment - I've added a patch for master, but it should cherry-pick cleanly onto the other branches.
        Hide
        Sam Hemelryk added a comment -

        Thanks Davo, changes look spot on and I've confirmed they backport perfectly so I am putting this up for integration now.
        Integrators please cherry-pick back to 2.2+ and 2.1+.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Davo, changes look spot on and I've confirmed they backport perfectly so I am putting this up for integration now. Integrators please cherry-pick back to 2.2+ and 2.1+. Cheers Sam
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Aparup Banerjee added a comment -

        Thanks guys, thats been integrated into 21, 22 and master. Ready for testing.

        Show
        Aparup Banerjee added a comment - Thanks guys, thats been integrated into 21, 22 and master. Ready for testing.
        Hide
        Rossiani Wijaya added a comment -

        This is working fine.

        Test passed.

        Show
        Rossiani Wijaya added a comment - This is working fine. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: