Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31959

Some notifications are marked as headings in user profile page

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: General
    • Labels:
    • Testing Instructions:
      Hide

      Login as student and access this url: http://yoursite.for.moodle/user/profile.php?id=## (replace ## with other user id).
      make sure the 'The details of this user are not available to you' message is not in heading tag.

      Modified the user table. set deleted for one of the user. then use that user id for the url above.
      make sure the 'This user account has been deleted' message is not in heading tag.

      Show
      Login as student and access this url: http://yoursite.for.moodle/user/profile.php?id=## (replace ## with other user id). make sure the 'The details of this user are not available to you' message is not in heading tag. Modified the user table. set deleted for one of the user. then use that user id for the url above. make sure the 'This user account has been deleted' message is not in heading tag.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When you for example try to view a user profile that you don't have access the notification below is outputted as heading.
      "The details of this user are not available to you"

      It should probably be a notification. This holds also for message: "This user account has been deleted"

        Gliffy Diagrams

          Attachments

            Activity

            juonio Juho Viitasalo created issue -
            juonio Juho Viitasalo made changes -
            Field Original Value New Value
            Labels patch
            juonio Juho Viitasalo made changes -
            Summary Some notifications are marked as headings when viewing user profile Some notifications are marked as headings in user profile page
            juonio Juho Viitasalo made changes -
            Pull Master Diff URL https://github.com/jiv-e/moodle/compare/master...MDL-31959-Changing-notification-output-in-user-profile-page
            Pull Master Branch MDL-31959-Changing-notification-output-in-user-profile-page
            Pull from Repository https://github.com/jiv-e/moodle
            juonio Juho Viitasalo made changes -
            salvetore Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels patch patch triaged
            Difficulty Easy [ 10023 ]
            rwijaya Rossiani Wijaya made changes -
            Fix Version/s STABLE Sprint 23 Alpha [ 12358 ]
            Fix Version/s STABLE backlog [ 10463 ]
            Assignee moodle.com [ moodle.com ] Rossiani Wijaya [ rwijaya ]
            moodle.com moodle.com made changes -
            Fix Version/s STABLE Sprint 23 Omega [ 12362 ]
            Fix Version/s STABLE Sprint 23 Alpha [ 12358 ]
            rwijaya Rossiani Wijaya made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            Peer reviewer ankit_frenz
            ankit_frenz Ankit Agarwal made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            rwijaya Rossiani Wijaya made changes -
            Testing Instructions Login as student and access this url: http://yoursite.for.moodle/user/profile.php?id=## (replace ## with other user id).
            make sure the 'The details of this user are not available to you' message is not in heading tag.

            Modified the user table. set deleted for one of the user. then use that user id for the url above.
            make sure the 'This user account has been deleted' message is not in heading tag.
            ankit_frenz Ankit Agarwal made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            rwijaya Rossiani Wijaya made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            nebgor Aparup Banerjee made changes -
            Currently in integration Yes [ 10041 ]
            nebgor Aparup Banerjee made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator nebgor
            nebgor Aparup Banerjee made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Affects Version/s 2.3.1 [ 12253 ]
            Affects Version/s 2.2.4 [ 12162 ]
            Affects Version/s 2.4 [ 12255 ]
            Affects Version/s 2.2.1 [ 11456 ]
            Fix Version/s 2.2.5 [ 12352 ]
            Fix Version/s 2.3.2 [ 12353 ]
            abgreeve Adrian Greeve made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester abgreeve
            abgreeve Adrian Greeve made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            stronk7 Eloy Lafuente (stronk7) made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 31/Aug/12
            stronk7 Eloy Lafuente (stronk7) made changes -
            Fix Version/s STABLE Sprint 23 Omega [ 12362 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12