Moodle
  1. Moodle
  2. MDL-31965

Breadcrumbs disappears when students launch activities with conditional availability set

    Details

    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      38627

      Description

      When a student role enter a SCORM activity where a conditional availability is set, breadcrumbs disappears. The issue is not present when attempting the same SCORM with an admin account. Moodle 2.2.1+ (Build: 20120301)

      Set up

      • in a site with completion and conditional subsystems enabled, create a course and enable completion tracking
      • add two SCORM (say, SC1 and SC2) activities to the course
      • for both SC1 and SC2 scorms, set completion criteria to "Student must view this activity to complete it"
      • for SC2 scorm, add conditional availability "SC1 scorm must be marked complete"
      • at this point you should end up with an activities sequence where a student 1) attempt SC1 and complete it, then 2) can attempt SC2 and complete it

      Test

      • access the course as student, attempt SC1. Breadcrumbs are shown normally
      • once SC1 is completed, attempt SC2 (the one with conditional activity set). SC2 launches, however breadcrumbs disappears.

      Please note that removing conditional activity setting from SC2, breadcrumbs are shown normally.

        Issue Links

          Activity

          Hide
          Andrea Bicciolo added a comment - - edited

          It appears any course activity is affected by this problem, I think wider investigation is needed.Adding watchers, removing SCORM as component and adding Navigation.

          it is also worth noticing navigation and setting blocks closes all their open trees while breadcrumbs disappears. Once activity is completed, logging in again let breadcrumbs reappear.

          Show
          Andrea Bicciolo added a comment - - edited It appears any course activity is affected by this problem, I think wider investigation is needed.Adding watchers, removing SCORM as component and adding Navigation. it is also worth noticing navigation and setting blocks closes all their open trees while breadcrumbs disappears. Once activity is completed, logging in again let breadcrumbs reappear.
          Hide
          Helen Foster added a comment -

          Assigning to moodle.com, as it's not specifically a SCORM issue.

          Show
          Helen Foster added a comment - Assigning to moodle.com, as it's not specifically a SCORM issue.
          Hide
          Andrea Bicciolo added a comment - - edited

          Added Sam H. as watcher.

          Show
          Andrea Bicciolo added a comment - - edited Added Sam H. as watcher.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Just to share that I was able to see the problem in action and it's really strange, sort of "navigation caching" not getting the changes in activity availability.

          And it affects both the breadcrumb (the first time you complete something), and the navigation tree (always).

          Only logging out/in makes both to be shown properly.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Just to share that I was able to see the problem in action and it's really strange, sort of "navigation caching" not getting the changes in activity availability. And it affects both the breadcrumb (the first time you complete something), and the navigation tree (always). Only logging out/in makes both to be shown properly. Ciao
          Hide
          Sam Hemelryk added a comment -

          Hi guys,
          I've just linked an issue MDL-31631 that is highlighting a problem with the navigation cache.
          It's not directly related to this problem however as part of that issue I will be reviewing the cache, and will now look into this at the same time just in case the two are related to the same cache issue.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I've just linked an issue MDL-31631 that is highlighting a problem with the navigation cache. It's not directly related to this problem however as part of that issue I will be reviewing the cache, and will now look into this at the same time just in case the two are related to the same cache issue. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Ok Eloy just walked me through a demo of this and we've identified two problems:
          1. Scorm needs to inform the navigation about its immediate redirection to player.php in some circumstances.
          2. Navigation cache is causing just opened activities to not be added. This will be resolved by MDL-31631 and the removal of the navigation cache (navigation will rely on modinfo which uses its own caching now).

          Show
          Sam Hemelryk added a comment - Ok Eloy just walked me through a demo of this and we've identified two problems: 1. Scorm needs to inform the navigation about its immediate redirection to player.php in some circumstances. 2. Navigation cache is causing just opened activities to not be added. This will be resolved by MDL-31631 and the removal of the navigation cache (navigation will rely on modinfo which uses its own caching now).
          Hide
          Andrea Bicciolo added a comment -

          Eloy, Sam,
          thank you very much for looking at this.

          @Sam:
          1. the issue is reproducible for all activity modules we tested (quiz, forum, glossary, folder, file) so probably also other modules need to inform the navigation on what they are doing
          2. MDL-31631 appears to affect 2.3 branch, while MDL-31965 affects 2.2 branch. In case they are related, there are back porting plans ?

          Show
          Andrea Bicciolo added a comment - Eloy, Sam, thank you very much for looking at this. @Sam: 1. the issue is reproducible for all activity modules we tested (quiz, forum, glossary, folder, file) so probably also other modules need to inform the navigation on what they are doing 2. MDL-31631 appears to affect 2.3 branch, while MDL-31965 affects 2.2 branch. In case they are related, there are back porting plans ?
          Hide
          Martin Dougiamas added a comment -

          Sam, if you're able to work on this, great, but otherwise let's make sure it gets into the sprint.

          Show
          Martin Dougiamas added a comment - Sam, if you're able to work on this, great, but otherwise let's make sure it gets into the sprint.
          Hide
          Sam Hemelryk added a comment -

          I've added this to the current sprint to ensure it gets looked at

          Show
          Sam Hemelryk added a comment - I've added this to the current sprint to ensure it gets looked at
          Hide
          Sam Hemelryk added a comment -

          Ok I've just been looking into this now and testing things.
          In master I've tested all activities with the suggested set up and everything appears to be fine.
          MDL-31631 has led to the navbar cache issues being fix in master, 2.2.3 and 2.1.6.
          For the life of me I couldn't produce the navbar errors within the Scorm module so I can only conclude that has been fixed in the past couple of weeks (or that I imagined it in the first place).

          Anyway looks like everything is OK now, I'll leave this open for a couple of days and if anyone is still experiencing issues please comment here with details otherwise this issue will be closed as already fixed.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Ok I've just been looking into this now and testing things. In master I've tested all activities with the suggested set up and everything appears to be fine. MDL-31631 has led to the navbar cache issues being fix in master, 2.2.3 and 2.1.6. For the life of me I couldn't produce the navbar errors within the Scorm module so I can only conclude that has been fixed in the past couple of weeks (or that I imagined it in the first place). Anyway looks like everything is OK now, I'll leave this open for a couple of days and if anyone is still experiencing issues please comment here with details otherwise this issue will be closed as already fixed. Cheers Sam
          Hide
          Andrea Bicciolo added a comment - - edited

          Hi Sam,

          we are in the process of testing the issue, currently it appears to be solved, however let the issue remain open, we will follow up shortly once we complete some more testing. Thanks,

          Show
          Andrea Bicciolo added a comment - - edited Hi Sam, we are in the process of testing the issue, currently it appears to be solved, however let the issue remain open, we will follow up shortly once we complete some more testing. Thanks,
          Hide
          Michael de Raadt added a comment -

          It looks like this may be fixed. I'm taking it off our list of bugs to fix for 2.3 and putting it into our next sprint so we can review it soon after 2.3 release.

          If you could let us know what your testing turns up before the, that would be useful.

          Show
          Michael de Raadt added a comment - It looks like this may be fixed. I'm taking it off our list of bugs to fix for 2.3 and putting it into our next sprint so we can review it soon after 2.3 release. If you could let us know what your testing turns up before the, that would be useful.
          Hide
          Sam Hemelryk added a comment -

          Closing this now as a duplicate (already appears to have been fixed).

          Please open a new issue with specifics if any of the issues mentioned here are found to still exist.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Closing this now as a duplicate (already appears to have been fixed). Please open a new issue with specifics if any of the issues mentioned here are found to still exist. Cheers Sam

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: