Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: Themes
    • Labels:
    • Rank:
      38643

      Description

      I was surprised to find in FW/styles/core.css about line 113

      .loginbox .loginform .form-label {
          float: none;
          width: 100%;
          margin: 0 auto;
          float: left;
          text-align: right;
          width: 40%;
      }
      

      so I deleted useless roles

        Activity

        Hide
        Daniele Cordella added a comment -

        I apologise for not have seeing this silly issue during last patch

        Show
        Daniele Cordella added a comment - I apologise for not have seeing this silly issue during last patch
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Daniele Cordella added a comment -

        Eloy, it so risk free this patch that I do not feel I am bad if I ask you to include it without integration review process. Ok, integration review is a crucial step but this patch is really "plain water".

        – Posted from Bugbox for iPhone

        Show
        Daniele Cordella added a comment - Eloy, it so risk free this patch that I do not feel I am bad if I ask you to include it without integration review process. Ok, integration review is a crucial step but this patch is really "plain water". – Posted from Bugbox for iPhone
        Hide
        Sam Hemelryk added a comment -

        Thanks Daniele, changes were 100% straight forward and have been integrated now.

        Show
        Sam Hemelryk added a comment - Thanks Daniele, changes were 100% straight forward and have been integrated now.
        Hide
        Adrian Greeve added a comment -

        I know that there are no test instructions, but I loaded up the login in form and inspected the page with firebug. Everything looks good.
        Thanks.

        Show
        Adrian Greeve added a comment - I know that there are no test instructions, but I loaded up the login in form and inspected the page with firebug. Everything looks good. Thanks.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: