Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.1, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: General
    • Labels:
    • Environment:
      PHP 5.3.5
    • Testing Instructions:
      Hide

      Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist).
      Open a Moodle page.
      You should NOT see a "syntax error, unexpected T_STRING" message.

      Show
      Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist). Open a Moodle page. You should NOT see a "syntax error, unexpected T_STRING" message.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31979-master
    • Rank:
      38647

      Description

      The example value for $CFG->extramemorylimit in config-dist.php is 1G, which is not a valid PHP literal. This should be quoted.

      (I'm not sure if this used to be valid syntax, but it isn't in PHP 5.3)

        Activity

        Hide
        Petr Škoda added a comment -

        ooops, thanks a lot for the report, submitting for integration.

        Show
        Petr Škoda added a comment - ooops, thanks a lot for the report, submitting for integration.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Some hours ago...

        the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Michael Aherne added a comment -

        Rebased.

        Show
        Michael Aherne added a comment - Rebased.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks! (21, 22 and master)

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 and master)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Quick tested here and confirmed. Now ok. Passing.

        Show
        Eloy Lafuente (stronk7) added a comment - Quick tested here and confirmed. Now ok. Passing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        FCT (fixed, closing, thanks). Ciao

        "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
        ~ Benjamin Disraeli

        Show
        Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: