Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-31979

Syntax error in config-dist.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.1, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: General
    • Labels:
    • Environment:
      PHP 5.3.5
    • Testing Instructions:
      Hide

      Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist).
      Open a Moodle page.
      You should NOT see a "syntax error, unexpected T_STRING" message.

      Show
      Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist). Open a Moodle page. You should NOT see a "syntax error, unexpected T_STRING" message.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31979-master

      Description

      The example value for $CFG->extramemorylimit in config-dist.php is 1G, which is not a valid PHP literal. This should be quoted.

      (I'm not sure if this used to be valid syntax, but it isn't in PHP 5.3)

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            skodak Petr Skoda added a comment -

            ooops, thanks a lot for the report, submitting for integration.

            Show
            skodak Petr Skoda added a comment - ooops, thanks a lot for the report, submitting for integration.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Some hours ago...

            the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            maherne Michael Aherne added a comment -

            Rebased.

            Show
            maherne Michael Aherne added a comment - Rebased.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (21, 22 and master)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 and master)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Quick tested here and confirmed. Now ok. Passing.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Quick tested here and confirmed. Now ok. Passing.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            FCT (fixed, closing, thanks). Ciao

            "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
            ~ Benjamin Disraeli

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12