Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.1, 2.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: General
    • Labels:
    • Environment:
      PHP 5.3.5
    • Testing Instructions:
      Hide

      Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist).
      Open a Moodle page.
      You should NOT see a "syntax error, unexpected T_STRING" message.

      Show
      Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist). Open a Moodle page. You should NOT see a "syntax error, unexpected T_STRING" message.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-31979-master

      Description

      The example value for $CFG->extramemorylimit in config-dist.php is 1G, which is not a valid PHP literal. This should be quoted.

      (I'm not sure if this used to be valid syntax, but it isn't in PHP 5.3)

        Gliffy Diagrams

          Activity

          Michael Aherne created issue -
          Michael Aherne made changes -
          Field Original Value New Value
          Pull Master Diff URL https://github.com/micaherne/moodle/commit/4fb84e5eae2d881ee813010873b27aebef2ad876
          Pull Master Branch MDL-31979-master
          Pull from Repository git://github.com/micaherne/moodle.git
          Michael Aherne made changes -
          Priority Minor [ 4 ] Trivial [ 5 ]
          Michael Aherne made changes -
          Description The example code for $CFG->extramemorylimit in config-dist.php is 1G, which is not a valid PHP literal. This should be quoted.

          (I'm not sure if this used to be valid syntax, but it isn't in PHP 5.3)
          The example value for $CFG->extramemorylimit in config-dist.php is 1G, which is not a valid PHP literal. This should be quoted.

          (I'm not sure if this used to be valid syntax, but it isn't in PHP 5.3)
          Petr Skoda made changes -
          Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
          Hide
          Petr Skoda added a comment -

          ooops, thanks a lot for the report, submitting for integration.

          Show
          Petr Skoda added a comment - ooops, thanks a lot for the report, submitting for integration.
          Petr Skoda made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Fix Version/s 2.0.8 [ 11554 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Fix Version/s 2.3 [ 10657 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Some hours ago...

          the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Some hours ago... the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.0.9 [ 12051 ]
          Fix Version/s 2.0.8 [ 11554 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.1.6 [ 12052 ]
          Fix Version/s 2.1.5 [ 11553 ]
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.2.3 [ 12053 ]
          Fix Version/s 2.2.2 [ 11552 ]
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Michael de Raadt made changes -
          Labels triaged
          Hide
          Michael Aherne added a comment -

          Rebased.

          Show
          Michael Aherne added a comment - Rebased.
          Eloy Lafuente (stronk7) made changes -
          Testing Instructions Uncomment the line with $CFG->extramemorylimit in config.php.
          Open a Moodle page.
          You should see a "syntax error, unexpected T_STRING" message.
          Uncomment the line with $CFG->extramemorylimit in config.php (copied from config-dist).
          Open a Moodle page.
          You should NOT see a "syntax error, unexpected T_STRING" message.
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (21, 22 and master)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (21, 22 and master)
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Affects Version/s 2.1.5 [ 11553 ]
          Affects Version/s 2.3 [ 10657 ]
          Fix Version/s 2.3 [ 10657 ]
          Fix Version/s 2.0.9 [ 12051 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Quick tested here and confirmed. Now ok. Passing.

          Show
          Eloy Lafuente (stronk7) added a comment - Quick tested here and confirmed. Now ok. Passing.
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          FCT (fixed, closing, thanks). Ciao

          "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
          ~ Benjamin Disraeli

          Show
          Eloy Lafuente (stronk7) added a comment - FCT (fixed, closing, thanks). Ciao "I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!" ~ Benjamin Disraeli
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 15/Mar/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: