Moodle
  1. Moodle
  2. MDL-31984

add developer debug message if THEME/renderers.php file is missing but THEME/renderer.php file is present

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.3
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Themes
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      With developer debugging enabled, rename a theme's renderers.php file to renderer.php.

      Show
      With developer debugging enabled, rename a theme's renderers.php file to renderer.php.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Rank:
      38652

      Description

      As suggested at http://moodle.org/mod/forum/discuss.php?d=187687, add a developer debugging message if THEME/renderers.php is missing and THEME/renderer.php is present.

        Activity

        Hide
        Brian Jorgensen added a comment -

        Sorry, that patch doesn't apply. I will create a new one.

        Show
        Brian Jorgensen added a comment - Sorry, that patch doesn't apply. I will create a new one.
        Hide
        Brian Jorgensen added a comment -

        New patch for 2.1.3.

        Show
        Brian Jorgensen added a comment - New patch for 2.1.3.
        Hide
        Tim Hunt added a comment -

        This looks like a nice simple fix to me.

        Just one coding style issue: the debugging(... line is two long. You should line-wrap it. http://docs.moodle.org/dev/Coding_style#Maximum_Line_Length

        Can you submit this fix as a git commit? That is really what we need to be able to integrate this.

        Show
        Tim Hunt added a comment - This looks like a nice simple fix to me. Just one coding style issue: the debugging(... line is two long. You should line-wrap it. http://docs.moodle.org/dev/Coding_style#Maximum_Line_Length Can you submit this fix as a git commit? That is really what we need to be able to integrate this.
        Hide
        Michael de Raadt added a comment -

        Hi, Brian.

        Thanks for sharing this. Please keep working on it, if you wish.

        Show
        Michael de Raadt added a comment - Hi, Brian. Thanks for sharing this. Please keep working on it, if you wish.
        Hide
        Brian Jorgensen added a comment -

        Linewrapped as requested; also generated using git show. Please let me know if it would be helpful for me to figure out all branches it applies cleanly against.

        Show
        Brian Jorgensen added a comment - Linewrapped as requested; also generated using git show. Please let me know if it would be helpful for me to figure out all branches it applies cleanly against.
        Hide
        Tim Hunt added a comment -

        Have a look at http://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=11350, the bit in the top middle, Weekly: Current integration. Look at some of the issues there. That should show you what an issue ready for integration looks like.

        Show
        Tim Hunt added a comment - Have a look at http://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=11350 , the bit in the top middle, Weekly: Current integration. Look at some of the issues there. That should show you what an issue ready for integration looks like.
        Hide
        Brian Jorgensen added a comment -

        I've pushed this commit up to github and added the fields here; it applies cleanly to MOODLE_20_STABLE and MOODLE_21_STABLE and MOODLE_22_STABLE.

        Show
        Brian Jorgensen added a comment - I've pushed this commit up to github and added the fields here; it applies cleanly to MOODLE_20_STABLE and MOODLE_21_STABLE and MOODLE_22_STABLE.
        Hide
        Tim Hunt added a comment -

        Looks good to me. Submitting for integration.

        To INTEGRATORS: please cherry-pick to all branches 2.1 -> master.

        Show
        Tim Hunt added a comment - Looks good to me. Submitting for integration. To INTEGRATORS: please cherry-pick to all branches 2.1 -> master.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Sam Hemelryk added a comment -

        Thanks guys this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks guys this has been integrated now
        Hide
        Adrian Greeve added a comment -

        This does as described. It will display a developer hint prompting a rename of the renderer.php file to renderers.php
        Thanks.

        Show
        Adrian Greeve added a comment - This does as described. It will display a developer hint prompting a rename of the renderer.php file to renderers.php Thanks.
        Hide
        Sam Hemelryk added a comment -

        Congratulations are in order, you've made it, or at least your code has!
        It's now part of Moodle and both the git and cvs repositories have been updated.

        This issue is being marked as fixed and closed.

        Thank you.

        Show
        Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: