Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: 2.1.7, 2.2.4, 2.3.1
Affects Version/s: 2.1.5, 2.2.2
Component/s: Assignment (2.2)
Labels:
- partner
- patch
- triaged

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/rwijaya/moodle.git
Pull Main Branch:
~~MDL-31987~~_assignment
Pull Main Diff URL:
https://github.com/rwijaya/moodle/compare/master...MDL-31987_assignment
Testing Instructions:

Hide

THIS ISSUE MUST BE TESTED WITH ALL 4 DBS.

1. Add a advanced upload assignment and make sure the 'Enable "Send for marking" button' is set to No.
2. Upload some files in students accounts
3. In assignment page, teacher should see the number of submissions for all student.
4. as admin, change the assignment setting "Send for marking" to yes
5. as student, submit the assignment for final submission
6. In assignment page, teacher should see the number of submissions for student that had clicked the 'final submission' button.

Repeat the test with different databases.

Show
THIS ISSUE MUST BE TESTED WITH ALL 4 DBS. 1. Add a advanced upload assignment and make sure the 'Enable "Send for marking" button' is set to No. 2. Upload some files in students accounts 3. In assignment page, teacher should see the number of submissions for all student. 4. as admin, change the assignment setting "Send for marking" to yes 5. as student, submit the assignment for final submission 6. In assignment page, teacher should see the number of submissions for student that had clicked the 'final submission' button. Repeat the test with different databases.

The bug was introduced in the latest patch: https://github.com/moodle/moodle/commit/9af65cb3accae49a18877f9ebbd508041d67765a

For advanced upload assignment, if teachers does not enable the "Send for marking" button, they will always get "No attempts have been made on this assignment" no matter how many students have uploaded.

has been marked as being related by

MDL-32948 Improved labelling/help of "send for marking" setting in the assignment configuration form.

Closed

is a regression caused by

MDL-30724 assignment_count_real_submissions() assumes all rows with a positive timestamp are "real submissions" when this is not true for upload assignment types

Closed

is blocked by

MDL-32207 assignment_count_real_submissions() for Advanced upload causes error

Closed

is duplicated by

MDL-32121 "No attempts have been made on this assignment" when there are.

Closed

MDL-33660 After upgraded to 2.2.3, view assignment get ORA-00932 "inconsistent datatypes: expected - got CLOB"

Closed

will help resolve

MDL-32207 assignment_count_real_submissions() for Advanced upload causes error

Closed

MDL-31221 Assignment setting 'Send for Marking' is required to update assignment_submissions.data2

Closed

(2 will help resolve)

Assignee:: Rossiani Wijaya

Reporter:: Sunner Sun

Peer reviewer:: Ankit Agarwal

Integrator:: Dan Poltawski

Tester:: Aparup Banerjee

Participants:: Ankit Agarwal, Aparup Banerjee, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Ian Luxton, Michael de Raadt, Rossiani Wijaya, Sam Hemelryk, Sebastian Tennant, Steven Chu, Sunner Sun, Tim Barker

Votes:: 34 Vote for this issue

Watchers:: 32 Start watching this issue

Created:: 11/Mar/12 3:17 PM

Updated:: 28/Jul/18 1:16 AM

Resolved:: 06/Jul/12 4:18 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates

Clockify