Moodle
  1. Moodle
  2. MDL-32027

Messaging: remove remains of old installation methods

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.3
    • Component/s: Installation, Messages
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Testing installation:

      1. Install Moodle using clean database
      2. Make sure that three message processors (email, jabber, popup) are available in the system (check Site Admin -> Plugins -> Message outputs -> Manage message outputs)

      Testing on installed Moodle (optional):

      1. Delete email message processor the most convenient way (MDL-32009 may simplify this task), make sure relevant database records are deleted.
      2. Go to Site Administration -> Notifications and install email processor, ensure email processor is available in the system.
      3. Repeat step 1 and 2 for jabber and pop-up processors.
      Show
      Testing installation: Install Moodle using clean database Make sure that three message processors (email, jabber, popup) are available in the system (check Site Admin -> Plugins -> Message outputs -> Manage message outputs) Testing on installed Moodle (optional): Delete email message processor the most convenient way ( MDL-32009 may simplify this task), make sure relevant database records are deleted. Go to Site Administration -> Notifications and install email processor, ensure email processor is available in the system. Repeat step 1 and 2 for jabber and pop-up processors.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32027-master-1
    • Rank:
      38699

      Description

      Processors installation is done using db/install.php. <processor>_install() functions in lib.php are obsolete since introduction of MDL-17457 and can be safely removed.

        Issue Links

          Activity

          Hide
          Ruslan Kabalin added a comment -

          Can be cherry-picked to earlier versions

          Show
          Ruslan Kabalin added a comment - Can be cherry-picked to earlier versions
          Hide
          Ruslan Kabalin added a comment -

          Dan, can you please review this.

          Show
          Ruslan Kabalin added a comment - Dan, can you please review this.
          Hide
          Dan Poltawski added a comment -

          Looks good for master only.

          Please include good testing instructions so we can be sure that this isn't affecting anything before submitting for integration.

          Show
          Dan Poltawski added a comment - Looks good for master only. Please include good testing instructions so we can be sure that this isn't affecting anything before submitting for integration.
          Hide
          Ruslan Kabalin added a comment -

          Testing instruction is added.

          Show
          Ruslan Kabalin added a comment - Testing instruction is added.
          Hide
          Dan Poltawski added a comment -

          Perhaps add something about testing moodle install and other areas this may cause regession in?

          Please add those and submit for integration - no need for peer review again.

          Show
          Dan Poltawski added a comment - Perhaps add something about testing moodle install and other areas this may cause regession in? Please add those and submit for integration - no need for peer review again.
          Hide
          Ruslan Kabalin added a comment -

          Perhaps add something about testing moodle install and other areas this may cause regession in?

          Modified testing instruction. I doubt it may cause regression anywhere. The similar bits of code (*_install() functions) for other plugins have been removed long time ago.

          Show
          Ruslan Kabalin added a comment - Perhaps add something about testing moodle install and other areas this may cause regession in? Modified testing instruction. I doubt it may cause regression anywhere. The similar bits of code (*_install() functions) for other plugins have been removed long time ago.
          Hide
          Sam Hemelryk added a comment -

          Thanks Ruslan, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Ruslan, this has been integrated now.
          Hide
          Rajesh Taneja added a comment -

          On master clean install, all three message processors are visible. Although I can't figure out a way to test optional test.
          Probably it (optional test) will be tested in MDL-32009.

          Show
          Rajesh Taneja added a comment - On master clean install, all three message processors are visible. Although I can't figure out a way to test optional test. Probably it (optional test) will be tested in MDL-32009 .
          Hide
          Ruslan Kabalin added a comment -

          That is true, "optional test" is already recorded in "Uninstall" testing section in MDL-32009. So I suggest to skip optional one in this bug. Thanks Rajesh for testing it, by the way

          Show
          Ruslan Kabalin added a comment - That is true, "optional test" is already recorded in "Uninstall" testing section in MDL-32009 . So I suggest to skip optional one in this bug. Thanks Rajesh for testing it, by the way
          Hide
          Rajesh Taneja added a comment -

          Pleasure

          Show
          Rajesh Taneja added a comment - Pleasure
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has landed upstream, finally! Yay!

          תודה רבה && شكرا جزيلا



          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: