Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.2.3
    • Component/s: Database SQL/XMLDB
    • Labels:

      Description

      The documentation of the record_exists() contains a relict from 1.x version that is not valid any more and can be very confusing for developers:

      • The record to test is specified by giving up to three fields that must
      • equal the corresponding values.

      I am suggesting to remove these two lines completely

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Hi, Apu.

            I thought you might want to tackle this as you have recenly been working on the phpDocs for this API.

            Show
            salvetore Michael de Raadt added a comment - Hi, Apu. I thought you might want to tackle this as you have recenly been working on the phpDocs for this API.
            Hide
            nebgor Aparup Banerjee added a comment -

            yup thanks, patch is up for review.

            Show
            nebgor Aparup Banerjee added a comment - yup thanks, patch is up for review.
            Hide
            skodak Petr Skoda added a comment -

            looks ok, please submit for integration

            Show
            skodak Petr Skoda added a comment - looks ok, please submit for integration
            Hide
            andyjdavis Andrew Davis added a comment -

            Looks like a good change. Consider also rewriting "Test whether a record exists in a table where all the given conditions met."

            Maybe something like...

            "Test whether a record that satisfies the supplied conditions exists."

            Or something.

            Show
            andyjdavis Andrew Davis added a comment - Looks like a good change. Consider also rewriting "Test whether a record exists in a table where all the given conditions met." Maybe something like... "Test whether a record that satisfies the supplied conditions exists." Or something.
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks, that has been integrated now.

            Show
            poltawski Dan Poltawski added a comment - Thanks, that has been integrated now.
            Hide
            poltawski Dan Poltawski added a comment -

            Passing test - comment removed succesfully

            Show
            poltawski Dan Poltawski added a comment - Passing test - comment removed succesfully
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            And this has landed upstream, finally! Yay!

            תודה רבה && شكرا جزيلا



            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12