Details
-
Type:
Sub-task
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.2
-
Fix Version/s: 2.2.3
-
Component/s: Database SQL/XMLDB
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
-
Rank:38702
Description
The documentation of the record_exists() contains a relict from 1.x version that is not valid any more and can be very confusing for developers:
- The record to test is specified by giving up to three fields that must
- equal the corresponding values.
I am suggesting to remove these two lines completely
Activity
yup thanks, patch is up for review.
Show
Aparup Banerjee
added a comment - yup thanks, patch is up for review.
looks ok, please submit for integration
Show
Petr Škoda
added a comment - looks ok, please submit for integration
Looks like a good change. Consider also rewriting "Test whether a record exists in a table where all the given conditions met."
Maybe something like...
"Test whether a record that satisfies the supplied conditions exists."
Or something.
Show
Andrew Davis
added a comment - Looks like a good change. Consider also rewriting "Test whether a record exists in a table where all the given conditions met."
Maybe something like...
"Test whether a record that satisfies the supplied conditions exists."
Or something.
Thanks, that has been integrated now.
Show
Dan Poltawski
added a comment - Thanks, that has been integrated now.
Passing test - comment removed succesfully 
Show
Dan Poltawski
added a comment - Passing test - comment removed succesfully
Show
Eloy Lafuente (stronk7)
added a comment - And this has landed upstream, finally! Yay!
תודה רבה && شكرا جزيلا
Closing, ciao
Hi, Apu.
I thought you might want to tackle this as you have recenly been working on the phpDocs for this API.