Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32036

Repositories wikimedia and youtube lack paging (backport)

    Details

    • Testing Instructions:
      Hide

      1. Enable repositories wikimedia and youtube
      2. Open any text editor and insert media from youtube, make sure that search and pagination work
      3. Open any text editor and insert image from wikimedia, make sure that search and pagination work
      4. repeat 2 and 3 with Javascript disabled, make sure everything works. Please note, that the pagination without JS is not absolutely correct (page #1 does not work), there is a separate issue for that

      Show
      1. Enable repositories wikimedia and youtube 2. Open any text editor and insert media from youtube, make sure that search and pagination work 3. Open any text editor and insert image from wikimedia, make sure that search and pagination work 4. repeat 2 and 3 with Javascript disabled, make sure everything works. Please note, that the pagination without JS is not absolutely correct (page #1 does not work), there is a separate issue for that
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE

      Description

      Backporting issue MDL-31929:

      repositories wikimedia and youtube:

      • save last search in $SESSION
      • process parameter 'page'
      • remove buttons 'Refresh', 'Search' and 'Logout' since they don't have meaning

      filepicker:

      • allow unknown number of pages ($data['pages'] = -1), show one 'Next' page after the current (both JS and non-JS modes)

      repository wikimedia:

      • add non-AJAX search form to make it work with JS disabled

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Marina this has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Marina this has been integrated now
            Hide
            phalacee Jason Fowler added a comment -

            Works fine

            Show
            phalacee Jason Fowler added a comment - Works fine
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Congratulations are in order, you've made it, or at least your code has!
            It's now part of Moodle and both the git and cvs repositories have been updated.

            This issue is being marked as fixed and closed.

            Thank you.

            Show
            samhemelryk Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12