Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32055

typo in pluginfile check for flash version

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.8, 2.1.5
    • Fix Version/s: 2.1.6
    • Component/s: Files API
    • Labels:
    • Testing Instructions:
      Hide

      increase required flash player version higher than the version you have installed.
      make sure developer debugging and display errors is on.
      Load a SCORM package (that uses flash) - blank page returned before this patch is applied.

      Show
      increase required flash player version higher than the version you have installed. make sure developer debugging and display errors is on. Load a SCORM package (that uses flash) - blank page returned before this patch is applied.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE

      Description

      Undefined constant O - causes blank page instead of flash player warning if unsupported flash version installed and debugging turned on.

      send_file($path, $filename, O, 0, false, false, 'application/x-shockwave-flash'); // Do not cache

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            danmarsden Dan Marsden added a comment -

            This only applies to 2.1 - 2.0 is out of bug support, and this isn't an issue in 2.2 as the flash player check has been removed

            Show
            danmarsden Dan Marsden added a comment - This only applies to 2.1 - 2.0 is out of bug support, and this isn't an issue in 2.2 as the flash player check has been removed
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            W0W good spotting Dan, your fix has been integrated now

            Show
            samhemelryk Sam Hemelryk added a comment - W0W good spotting Dan, your fix has been integrated now
            Hide
            skodak Petr Skoda added a comment -

            confirming there are no more of these O typos in master

            Show
            skodak Petr Skoda added a comment - confirming there are no more of these O typos in master
            Hide
            phalacee Jason Fowler added a comment -

            I've tried testing this, but can't seem to get any thing working, something to do with the fact my install needs slash arguments but SCORM doesn't work well with them ...

            Show
            phalacee Jason Fowler added a comment - I've tried testing this, but can't seem to get any thing working, something to do with the fact my install needs slash arguments but SCORM doesn't work well with them ...
            Hide
            danmarsden Dan Marsden added a comment -

            Hi Jason, check out the SCORM FAQ on the docs for details on the fix but you don't need to test this with SCORM - any uploaded flash should work.

            Show
            danmarsden Dan Marsden added a comment - Hi Jason, check out the SCORM FAQ on the docs for details on the fix but you don't need to test this with SCORM - any uploaded flash should work.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            It works fine.

            Test passed.

            Show
            rwijaya Rossiani Wijaya added a comment - It works fine. Test passed.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Congratulations are in order, you've made it, or at least your code has!
            It's now part of Moodle and both the git and cvs repositories have been updated.

            This issue is being marked as fixed and closed.

            Thank you.

            Show
            samhemelryk Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  14/May/12