Moodle
  1. Moodle
  2. MDL-32057

Cohort enrolment display in IE7 renders incorrectly

    Details

      Description

      When viewing the cohort enrolment screen for a course (Course Admin > Enrolled users > Enrol Cohort button), the name and member count of the cohort is displayed at the bottom of the div and rendered unreadable because of this.

        Gliffy Diagrams

          Activity

          Hide
          Petr Skoda added a comment -

          reassigning, I am sorry, I do not have access to IE browsers (except win8preview)

          Show
          Petr Skoda added a comment - reassigning, I am sorry, I do not have access to IE browsers (except win8preview)
          Hide
          Michael de Raadt added a comment -

          Hi, Adam.

          Thanks for contributing this. I've just triaged the issue.

          I've now included in you the developer group. If you'd like to advance this further, you can request peer review of your issue.

          Show
          Michael de Raadt added a comment - Hi, Adam. Thanks for contributing this. I've just triaged the issue. I've now included in you the developer group. If you'd like to advance this further, you can request peer review of your issue.
          Hide
          Adam Olley added a comment -

          Thanks Michael. Is there actually an action I follow to request that, or it's just something I put in the comments? I see I can "Start peer review" but that seems to me like it should be used by the reviewer when they begin work?

          Show
          Adam Olley added a comment - Thanks Michael. Is there actually an action I follow to request that, or it's just something I put in the comments? I see I can "Start peer review" but that seems to me like it should be used by the reviewer when they begin work?
          Hide
          Tim Lock added a comment -

          Hi Sam,

          Are you able to start the peer review?

          Show
          Tim Lock added a comment - Hi Sam, Are you able to start the peer review?
          Hide
          Tim Lock added a comment -

          Hi Sam,

          Are you able to start the peer review?

          Show
          Tim Lock added a comment - Hi Sam, Are you able to start the peer review?
          Hide
          Sam Hemelryk added a comment -

          Hi Adam,

          I've just looked at this now.
          Certainly the changes are fine, however as IE7 isn't a browser we officially support from 2.3 onwards I think it is best that the new styles are added separately with the .ie7 prefix. IE8 supports the display:inline-block style so no probs with future versions.
          Doing this allows us to tidy things up much easier when IE7 is dead and gone, although I realise that won't happen any time soon.

          .qce-panel .qce-cohort div,
          .qce-panel .canenrolusers .qce-cohort .qce-cohort-name {float:left;}
          

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Adam, I've just looked at this now. Certainly the changes are fine, however as IE7 isn't a browser we officially support from 2.3 onwards I think it is best that the new styles are added separately with the .ie7 prefix. IE8 supports the display:inline-block style so no probs with future versions. Doing this allows us to tidy things up much easier when IE7 is dead and gone, although I realise that won't happen any time soon. .qce-panel .qce-cohort div, .qce-panel .canenrolusers .qce-cohort .qce-cohort-name {float:left;} Cheers Sam
          Hide
          Adam Olley added a comment -

          Hi Sam,

          I've updated the commit with your suggestion and also rebased the branches.

          Show
          Adam Olley added a comment - Hi Sam, I've updated the commit with your suggestion and also rebased the branches.
          Hide
          Sam Hemelryk added a comment -

          Awesome thanks Adam, I've put this up for integration now.
          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Awesome thanks Adam, I've put this up for integration now. Cheers Sam
          Hide
          Dan Poltawski added a comment -

          Thanks Adam, i've integrated this to master, 22 and 23

          Show
          Dan Poltawski added a comment - Thanks Adam, i've integrated this to master, 22 and 23
          Hide
          Ankit Agarwal added a comment - - edited

          Hi Sam,
          The issue in hand seems fixed, but I got the following warning multiple time when loading the course enroll page
          "A script on this page is causing Internet Explorer to run slowly"
          Seems unrelated to me. Issue was only noticed on 23 and master. Works fine on 22.
          Please suggest if this worth failing this issue.

          Edit:- Looks like it is because of MDL-33448. passing the test.

          Thanks

          Show
          Ankit Agarwal added a comment - - edited Hi Sam, The issue in hand seems fixed, but I got the following warning multiple time when loading the course enroll page "A script on this page is causing Internet Explorer to run slowly" Seems unrelated to me. Issue was only noticed on 23 and master. Works fine on 22. Please suggest if this worth failing this issue. Edit:- Looks like it is because of MDL-33448 . passing the test. Thanks
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          You've made it into the weekly release!

          Thanks for your contribution - here are some random drummers to keep you inspired for the next week!
          http://www.youtube.com/watch?v=_QhpHUmVCmY

          Show
          Dan Poltawski added a comment - Congratulations! You've made it into the weekly release! Thanks for your contribution - here are some random drummers to keep you inspired for the next week! http://www.youtube.com/watch?v=_QhpHUmVCmY

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: