Moodle

Some images stored in 'pics' directory which prevents themeing

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.2.2
  • Fix Version/s: 2.1.6, 2.2.3
  • Component/s: Feedback
  • Labels:
  • Testing Instructions:
    Hide
    • Create a new feedback activity
    • Add a multichoice question
      • Set the required flag
      • Specify several answers
      • Specify values for other required fields
      • Save the question
    • Add a multichoice rated question
      • Set the required flag
      • Specify several answers
      • Specify values for other required fields
      • Save the question
    • Add a Short Text Answer question
      • Do not set the required flag
      • Specify values for other required fields
      • Save the question
    • Confirm:
      • The First question has the required flag displayed (yellow circle with exclamation mark)
      • The Second question has the notrequired flag displayed (greyed-out circle with exclamation mark)

    Log in as another user and complete the feedback activity
    Log in as another user and complete the feedback activity again - specify a different answer to the multichoice questions
    Log in as another user and complete the feedback activity again - specify whichever answers you feel like for the multichoice questions

    As teacher/admin again:

    • View the Analysis page
    • Confirm:
      • The bars for the Multichoice questions are filled and have different colours for each of the rankings (e.g. 1st is green, 2nd is red, etc)
    Show
    Create a new feedback activity Add a multichoice question Set the required flag Specify several answers Specify values for other required fields Save the question Add a multichoice rated question Set the required flag Specify several answers Specify values for other required fields Save the question Add a Short Text Answer question Do not set the required flag Specify values for other required fields Save the question Confirm: The First question has the required flag displayed (yellow circle with exclamation mark) The Second question has the notrequired flag displayed (greyed-out circle with exclamation mark) Log in as another user and complete the feedback activity Log in as another user and complete the feedback activity again - specify a different answer to the multichoice questions Log in as another user and complete the feedback activity again - specify whichever answers you feel like for the multichoice questions As teacher/admin again: View the Analysis page Confirm: The bars for the Multichoice questions are filled and have different colours for each of the rankings (e.g. 1st is green, 2nd is red, etc)
  • Difficulty:
    Easy
  • Affected Branches:
    MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-32065-master-1
  • Pull Master Diff URL:

Description

Our theme designer is trying to change the required and notrequired icons but is currently unable to do so because the existing icons are hardcoded to a directory within the feedback module (pics)

Issue Links

testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32070 Form warnings triggered when edit_form submitted with onChange JS

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Nicols added a comment -

I've moved all of the images to the pix directory and updated php where necessary to take effect.

Show
Andrew Nicols added a comment - I've moved all of the images to the pix directory and updated php where necessary to take effect.
Hide
Permalink
Dan Poltawski added a comment -

Looks good. Its a real shame this has been like this for 3 major releases

Show
Dan Poltawski added a comment - Looks good. Its a real shame this has been like this for 3 major releases
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Hi Andrew,

The changes look good thanks.
I'd just like to clarify, would you like this backported to the stable branches?
At the moment I think this only needs to go master as it is an improvement moving those image to the pix directory.
However I think if you do want to backported that wouldn't be a problem. However I will get you to produce 22 and 21 branches as it doesn't appear to backport cleanly.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Andrew, The changes look good thanks. I'd just like to clarify, would you like this backported to the stable branches? At the moment I think this only needs to go master as it is an improvement moving those image to the pix directory. However I think if you do want to backported that wouldn't be a problem. However I will get you to produce 22 and 21 branches as it doesn't appear to backport cleanly. Cheers Sam
Hide
Permalink
Andrew Nicols added a comment -

Hi Sam,

I hadn't expected it to get picked up for stable branches, but if you're happy to apply there:

  • it should cherry-pick cleanly to MOODLE_22_STABLE
  • I've now supplied a branch for MOODLE_21_STABLE

Cheers,

Andrew

Show
Andrew Nicols added a comment - Hi Sam, I hadn't expected it to get picked up for stable branches, but if you're happy to apply there: it should cherry-pick cleanly to MOODLE_22_STABLE I've now supplied a branch for MOODLE_21_STABLE Cheers, Andrew
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Andrew, this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
Hide
Permalink
Rossiani Wijaya added a comment -

This looks good.

Test passed.

Show
Rossiani Wijaya added a comment - This looks good. Test passed.
Hide
Permalink
Sam Hemelryk added a comment -

Congratulations are in order, you've made it, or at least your code has!
It's now part of Moodle and both the git and cvs repositories have been updated.

This issue is being marked as fixed and closed.

Thank you.

Show
Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: