Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32076

Unlimited Grades Not Accepted By Grader Report with AJAX Editing On

    Details

    • Testing Instructions:
      Hide

      For this test you will need a course with at least one student in it.

      Turn the site setting "unlimitedgrades" on.
      Make sure that the site setting "grade_report_enableajax" is on.
      Create an assignment with a maximum grade of 100.
      Go to the grader report.

      Click in the student row in the assignment column (ie the cell where the student assignment grade should go) and enter a valid grade ie 50
      The cell background color will change to show that the grade is now overridden (manually set within the gradebook instead of being supplied by the activity)
      Reload the page by clicking on "grader report" in the navigation bar.
      Check your change was actually saved.

      Enter a grade above 100 ie 120
      Reload the page by clicking on "grader report" in the navigation bar.
      Check your change was actually saved.
      Change the grade back to something under 100.

      Turn the site setting "unlimitedgrades" off.
      Enter a grade above 100 ie 120
      You should get an error saying "The grade entered for assignment for Sam Student is more than the maximum allowed"
      The display of the error dialog is kind of messed up. There is a linked issue to fix this.

      Enter a grade less than 100 and check that the change is saved.

      Show
      For this test you will need a course with at least one student in it. Turn the site setting "unlimitedgrades" on. Make sure that the site setting "grade_report_enableajax" is on. Create an assignment with a maximum grade of 100. Go to the grader report. Click in the student row in the assignment column (ie the cell where the student assignment grade should go) and enter a valid grade ie 50 The cell background color will change to show that the grade is now overridden (manually set within the gradebook instead of being supplied by the activity) Reload the page by clicking on "grader report" in the navigation bar. Check your change was actually saved. Enter a grade above 100 ie 120 Reload the page by clicking on "grader report" in the navigation bar. Check your change was actually saved. Change the grade back to something under 100. Turn the site setting "unlimitedgrades" off. Enter a grade above 100 ie 120 You should get an error saying "The grade entered for assignment for Sam Student is more than the maximum allowed" The display of the error dialog is kind of messed up. There is a linked issue to fix this. Enter a grade less than 100 and check that the change is saved.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:
      MDL-32076_unlimited2

      Description

      With both Unlimited Grades and AJAX Editing for the grader report turned on, the grader report will not allow grades higher than the maximum points to be entered via AJAX editing. It will allow grades higher than the maximum if you "Turn Editing On" and save the grade, but doing it via AJAX editing does not work.

      In 2.1.4, we are receiving an error message:
      "Error Click this box to remove it
      The grade entered for ... for student ... is more than the maximum allowed"

      In 2.2.1, I'm not receiving an error message. It looks like it saves the grade but refreshing the page reveals that it didn't save it.

      Steps to reproduce:
      1. Turn on Unlimited Grades in Site admin > Grades > General settings.
      2. Turn on AJAX Editing for Grader report in Site admin > Grades > Report settings > Grader report.
      3. Create an assignment (or probably any graded activity) with some point total, e.g. 10 points.
      4. On grader report, do not click "Turn Editing On." Click the assignment grade cell for any student to edit it.
      5. Enter a point value greater than the maximum set in step 3, e.g. 15 points. Press Enter to save.
      6. On 2.1.4, you'll get an error message.
      7. On 2.2.1, it appears to save. Refresh the page. It didn't save.

      This was reproduced on pure 2.1.4 and 2.2.1 sites with absolutely no non-standard plugins or customizations.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  11 Vote for this issue
                  Watchers:
                  14 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    11/Mar/13