Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: SCORM
    • Labels:
    • Rank:
      38776

      Description

      mod/scorm/styles.css - altpopuplink doesn't exist anymore, we should remove the css

      #page-mod-scorm-player #altpopuplink

      { position: left; padding: 5px; border: 0px; }

        Activity

        Hide
        Dan Marsden added a comment -

        note to integrator - MASTER only please.

        Show
        Dan Marsden added a comment - note to integrator - MASTER only please.
        Hide
        Dan Marsden added a comment -

        seems like a waste of time to send this for peer review, but here it is anyway.

        Show
        Dan Marsden added a comment - seems like a waste of time to send this for peer review, but here it is anyway.
        Hide
        Mary Evans added a comment -

        Hi Dan,

        If you add some test instructions I could Peer Review it.

        Even if there was an 'altpopuplink' it's styled wrong for starters!

        But as you say, if it's obsolete then no need to Peer Review, at least I would not have thought so.

        Show
        Mary Evans added a comment - Hi Dan, If you add some test instructions I could Peer Review it. Even if there was an 'altpopuplink' it's styled wrong for starters! But as you say, if it's obsolete then no need to Peer Review, at least I would not have thought so.
        Hide
        Dan Marsden added a comment -

        heh - I guess the problem is how to "test" for something that doesn't exist

        best option would be to use some find/replace tool and search moodle code for "altpopuplink" and make sure you don't find it anywhere!

        Show
        Dan Marsden added a comment - heh - I guess the problem is how to "test" for something that doesn't exist best option would be to use some find/replace tool and search moodle code for "altpopuplink" and make sure you don't find it anywhere!
        Hide
        Ankit Agarwal added a comment -

        No occurance of altpopuplink found.
        +1 to integrate!
        Thanks

        Show
        Ankit Agarwal added a comment - No occurance of altpopuplink found. +1 to integrate! Thanks
        Hide
        Sam Hemelryk added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Sam Hemelryk added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Dan Poltawski added a comment -

        Thanks Dan, this has been integrated now

        Show
        Dan Poltawski added a comment - Thanks Dan, this has been integrated now
        Hide
        Dan Poltawski added a comment -

        Can't find anywhere this CSS is used. Passing test.

        Show
        Dan Poltawski added a comment - Can't find anywhere this CSS is used. Passing test.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has landed upstream, finally! Yay!

        תודה רבה && شكرا جزيلا



        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: