Moodle
  1. Moodle
  2. MDL-32081

Bug with CSS optimiser and background images

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:

      Description

      The following CSS is causing the CSS optimiser to print out invalid CSS that is breaking the display of sites:

      #nextLink{width:49%;height:100%;background-image:url(data:image/gif;base64,AAAA);display:block}

      This should be tested with a unit test and obviously the CSS optimiser corrected.

        Gliffy Diagrams

          Activity

          Hide
          Sam Hemelryk added a comment -

          Putting this up for peer-review now.

          Show
          Sam Hemelryk added a comment - Putting this up for peer-review now.
          Hide
          Dan Poltawski added a comment -

          Wow, you had some fun in that CSS optimiser sam

          Looks good

          Show
          Dan Poltawski added a comment - Wow, you had some fun in that CSS optimiser sam Looks good
          Hide
          Sam Hemelryk added a comment -

          Thanks Dan, submitting for integration now.

          Haha year - that was something that started off in my personal time after getting absolutely fed up with some of the truly shocking CSS we have in our core themes.
          This CSS optimiser cleans up as much of that mess as it can and I have a new admin tool that makes use of it as well. It runs against all of the CSS in a theme, or in a plugin and then reports on its findings... there will be more changes arriving as I continue to work on that.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Dan, submitting for integration now. Haha year - that was something that started off in my personal time after getting absolutely fed up with some of the truly shocking CSS we have in our core themes. This CSS optimiser cleans up as much of that mess as it can and I have a new admin tool that makes use of it as well. It runs against all of the CSS in a theme, or in a plugin and then reports on its findings... there will be more changes arriving as I continue to work on that. Cheers Sam
          Hide
          Aparup Banerjee added a comment -

          This looks alright to me. integrated and up for testing.

          Tester: feel free to go nuts with some crazy CSS to help weed out bugs.

          Show
          Aparup Banerjee added a comment - This looks alright to me. integrated and up for testing. Tester: feel free to go nuts with some crazy CSS to help weed out bugs.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          while looking for some regressions in phpunit... I ended testing this... and passed. Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - while looking for some regressions in phpunit... I ended testing this... and passed. Ciao
          Hide
          Aparup Banerjee added a comment -

          The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

          Closing, have a good weekend!

          Show
          Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: