Moodle
  1. Moodle
  2. MDL-32084

Remove "Another Moodle theme" tagline from Fusion theme

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select Fusion theme
      2. Check that no tagline appears underneath the page heading in the header
      3. Select the Fusion custom settings page link from from the list in Site Admin > Appearance > Themes
      4. In the 'Tagline' option add a few words in the 'small' text-area box provided. Save settings and Test to see that the words you added appear beneath the page heading.
      Show
      Select Fusion theme Check that no tagline appears underneath the page heading in the header Select the Fusion custom settings page link from from the list in Site Admin > Appearance > Themes In the 'Tagline' option add a few words in the 'small' text-area box provided. Save settings and Test to see that the words you added appear beneath the page heading.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32084_master
    • Rank:
      38783

      Description

      The tagline is an optional setting, if you don't add a tagline the default is used. This has become a source of annoyance recently in the forums, as there is no way to leave it blank if you choose not to use the tagline setting, because the default is hardcoded in the page.

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for working on this, Mary.

        Show
        Michael de Raadt added a comment - Thanks for working on this, Mary.
        Hide
        Mary Evans added a comment - - edited

        Hi Michael,

        I got this wrong it was Fusion not FormFactor!
        I've done the changes, which involved removing the default tagline text from theme/fusion/layout/frontpage.php and also changed 'configtextarea' to 'configtext' in theme/fusion/settings.php as this reduces the size of the text area where you would add the 'short' tagline. I felt that original 'textarea' was way too big for what is supposed to be only a few words at best. Using 'configtext' adds a smaller, neater, text area for the tagline.

        Cheers
        Mary

        Show
        Mary Evans added a comment - - edited Hi Michael, I got this wrong it was Fusion not FormFactor! I've done the changes, which involved removing the default tagline text from theme/fusion/layout/frontpage.php and also changed 'configtextarea' to 'configtext' in theme/fusion/settings.php as this reduces the size of the text area where you would add the 'short' tagline. I felt that original 'textarea' was way too big for what is supposed to be only a few words at best. Using 'configtext' adds a smaller, neater, text area for the tagline. Cheers Mary
        Hide
        Mary Evans added a comment -

        Well that will teach me to go cherry-picking in the dead of night! I got nothing but conficts...was becasue I went from Moodle 22 to 21 and of course things have chaged in the layout files. I should have known better.

        Show
        Mary Evans added a comment - Well that will teach me to go cherry-picking in the dead of night! I got nothing but conficts...was becasue I went from Moodle 22 to 21 and of course things have chaged in the layout files. I should have known better.
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary - this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Mary - this has been integrated now
        Hide
        Ankit Agarwal added a comment -

        Testing went smoothly!
        passed!
        Thanks

        Show
        Ankit Agarwal added a comment - Testing went smoothly! passed! Thanks
        Hide
        Sam Hemelryk added a comment -

        Congratulations are in order, you've made it, or at least your code has!
        It's now part of Moodle and both the git and cvs repositories have been updated.

        This issue is being marked as fixed and closed.

        Thank you.

        Show
        Sam Hemelryk added a comment - Congratulations are in order, you've made it, or at least your code has! It's now part of Moodle and both the git and cvs repositories have been updated. This issue is being marked as fixed and closed. Thank you.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: