Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32092

Remove dead code from profile_field_textarea

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2
    • Fix Version/s: 2.4
    • Component/s: Other
    • Labels:

      Description

      edit_field_add method in profile_field_textarea declares $cols & $rows:

      $cols = $this->field->param1;
      $rows = $this->field->param2;

      but those are never used. They are also not set anywhere - there is no option in UI for custom profile textarea field to set number of columns and rows.
      I think that this is not really necessary to have cols & rows settable - so let's remove that dead code.

        Attachments

          Activity

            People

            Assignee:
            rwijaya Rossiani Wijaya
            Reporter:
            tmuras Tomasz Muras
            Peer reviewer:
            Ankit Agarwal
            Integrator:
            Dan Poltawski
            Tester:
            Mark Nelson
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Dec/12