[MDL-32096] Report - remove duplicate firstname and surname filter - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.2.2, 3.5.4, 3.6.2, 3.7
Fix Version/s: 3.5.5, 3.6.3
Component/s: Activity completion, Reports
Labels:
- ci
- triaged

Affected Branches:
MOODLE_22_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
Fixed Branches:
MOODLE_35_STABLE, MOODLE_36_STABLE
Pull from Repository:
git://github.com/peterRd/moodle.git
Pull Master Branch:
~~MDL-32096~~-master
Pull Master Diff URL:
https://github.com/peterRd/moodle/compare/4c5b60a0f9...MDL-32096-master
Testing Instructions:
Hide

Prerequisites:

Have a course with users enrolled and activities and completion tracking enabled (you can enable it from "Course admin menu > Edit settings > Completion tracking"

Go to "Course admin menu > Course completion" and tick the checkbox under "Condition: Manual self completion"

Create an activity in the course, enabling activity completion by selecting "Students can manually mark the activity as completed" for "Completion tracking" option

Instructions:

Go to the course you created

Go to 'Course administration' -> Reports -> 'Course completion'

Confirm only one set of name filters exists above the participants/activity table

Go to 'Course administration' -> Reports -> 'Activity completion'

Confirm only one set of name filters exists above the participants/activity table

Before

After
Show
Prerequisites: Have a course with users enrolled and activities and completion tracking enabled (you can enable it from "Course admin menu > Edit settings > Completion tracking" Go to "Course admin menu > Course completion" and tick the checkbox under "Condition: Manual self completion" Create an activity in the course, enabling activity completion by selecting "Students can manually mark the activity as completed" for "Completion tracking" option Instructions: Go to the course you created Go to 'Course administration' -> Reports -> 'Course completion' Confirm only one set of name filters exists above the participants/activity table Go to 'Course administration' -> Reports -> 'Activity completion' Confirm only one set of name filters exists above the participants/activity table Before After

Description

In "Activity Completion" and "Course Completion" page results in duplication of the firstname and surname filters (below the report data and above the download option links. The bottom instance should be removed and the filter set above should be aligned center instead of left.

Replication steps:

Select "Activity completion" from "Navigation" block -> My courses -> "Coursename" -> Reports
See filter duplication

Edit: Update the heading and content to include the other page where this occurs within the reporting module

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

activity_completion_filter_duplicate.png
103 kB
17/Mar/12 12:31 PM
after.png
81 kB
15/Jan/19 11:43 AM
before.png
107 kB
15/Jan/19 11:43 AM
MDL-32096.jpg
21 kB
13/Feb/19 3:37 PM

Issue Links

is parent of

MDL-64834 Add new pagination abilities

Open

Activity

People

Assignee:: Peter Dias

Reporter:: Eric Strom

Peer reviewer:: Mihail Geshoski

Integrator:: David Monllaó

Tester:: Anna Carissa Sadia

Participants:: Anna Carissa Sadia, Barbara Ramiro, CiBoT, David Monllaó, Eric Strom, Luca Bösch, Michael de Raadt, Mihail Geshoski, Peter Dias, Sam Marshall

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Dates

Created:: 17/Mar/12 12:28 PM

Updated:: 15/Feb/19 9:48 AM

Resolved:: 15/Feb/19 9:48 AM

Fix Release Date:: 11/Mar/19

Time Tracking

Estimated:

Remaining:

Logged:

10m