[MDL-32103] Make course completion instant for activity based completion criteria (single user completions only) - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 2.2, 2.8, 3.9.2, 3.10.4
Fix Version/s: 4.0
Component/s: Course completion
Labels:

Affected Branches:
MOODLE_22_STABLE, MOODLE_28_STABLE, MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
git://github.com/ilyatregubov/moodle.git
Pull Master Branch:
~~MDL-32103~~-master
Pull Master Diff URL:
https://github.com/ilyatregubov/moodle/compare/c357779722...MDL-32103-master
Testing Instructions:

Hide

Covered by Behat

Show
Covered by Behat

Sprint:
Moppies Kanban, Moppies Kanban

Description

At the moment Course Completion can be confusing to users as it does not always immediately occur. This is due to the part of the logic that marks a user complete in a course (when sufficient criteria are complete) occurs in the cron.

this is copied from the original report ~~MDL-27368~~

UPDATE: Just as info here. I only improved course completion based on activity completion. So initial tracker name might be confusing - we don't really move all completion from the cron (for performance reasons), we just add ability to mark course as complete without cron for activity based completion.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

course completion.png
258 kB
24/Mar/21 6:13 PM

Issue Links

caused a regression

MDL-75173 Course is marked as completed when conditions are not met for passing grade

Closed

has a non-specific relationship to

MDL-27368 course completion causes cron failure

Closed

has been marked as being related by

MDL-33320 Course completion cron code sometimes needs to run twice to mark students as complete

Open

MDL-75433 Access restriction not acknowledging passed-grade completion of quiz

Closed

has to be done before

MDL-64576 Course completion activity dates are incorrect if course completion criteria have been edited

Closed

MDL-72158 Remove unit tests customisation from aggregate_completions

Open

is blocked by

MDL-32203 Course completion data object misses records

Closed

MDL-71178 Grade activity completion criteria marks activity as complete when no grades is awarded

Closed

Testing discovered

MDL-72098 deprecate grade_grade::insert method that just calls its parent

Closed

(1 has to be done before, 2 is blocked by, 1 Testing discovered)

Sub-Tasks

1.	move /lib/completion/* out of lib and into /completion	Closed	Aparup Banerjee
2.	Rebase cron completion aggregation to suit single-user "realtime" aggregation	Closed	Unassigned
3.	Trigger completion criteria aggregation as soon as criteria are complete	Closed	Aaron Barnes
4.	"start" users in completion as soon as they become enrolled in a course	Closed	Unassigned
5.	architecture of completion's classes could be made to be more pluggable/modular	Closed	Unassigned
6.	Course completion unit testing	Closed	Unassigned

Activity

People

Assignee:: Ilya Tregubov

Reporter:: Dan Marsden

Peer reviewer:: Ferran Recio

Integrator:: Sara Arjona (@sarjona)

Tester:: CiBoT

Participants:: Aaron Barnes, Aparup Banerjee, Carlos Escobedo, CiBoT, Dan Marsden, David, Eloy Lafuente (stronk7), Ferran Recio, Ilya Tregubov, Jari Vilkman, Marina Glancy, Martin Dougiamas, Michael de Raadt, Nathan Mares, Peter Diedrichs, Sander Bangma, Sara Arjona (@sarjona), Simon Coggins, Timothy Orbasido

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 54 Vote for this issue

Watchers:: 49 Start watching this issue

Dates

Created:: 19/Mar/12 4:39 PM

Updated:: 21/Nov/22 10:56 PM

Resolved:: 16/Jul/21 10:57 AM

Fix Release Date:: 19/Apr/22

Time Tracking

Estimated:

Remaining:

Logged:

3w 3d 2h 19m

Include sub-tasks