Moodle
  1. Moodle
  2. MDL-32124

mails to non respondents are sent as plain text with html-tags

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      You need a moodle instance with email support.

      1. Create a non-anonymous feedback instance in a course with one or more students
      2. Go to the "Show non-respondents" page
      3. Select one or more users
      4. Write a message with some html formatings like header, bold and so so.
      5. Send this mail.
        Now you should receive an email with a text and a html body.
      Show
      You need a moodle instance with email support. Create a non-anonymous feedback instance in a course with one or more students Go to the "Show non-respondents" page Select one or more users Write a message with some html formatings like header, bold and so so. Send this mail. Now you should receive an email with a text and a html body.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32124_master_wip
    • Rank:
      38844

      Description

      If you send a mail to no respondents users with the editor integrated in the feedback module so the mail is sent in plain text but with html-tags.

        Activity

        Hide
        Michael de Raadt added a comment -

        Hi, Anreas.

        I've just triaged this, but please don't let that stop you from working on it.

        Show
        Michael de Raadt added a comment - Hi, Anreas. I've just triaged this, but please don't let that stop you from working on it.
        Hide
        Sam Hemelryk added a comment -

        Thanks Andreas, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Andreas, this has been integrated now
        Hide
        Andrew Davis added a comment -

        Tested in master, 2.2 and 2.1.

        Just a word about the testing instructions. Make sure to include all settings that alter the behaviour of the code in question. The feedback message behaviour is also affected by the recipients messaging settings and their email format profile setting. These settings can cause the tester to spend a long time wondering why its not working correctly

        Show
        Andrew Davis added a comment - Tested in master, 2.2 and 2.1. Just a word about the testing instructions. Make sure to include all settings that alter the behaviour of the code in question. The feedback message behaviour is also affected by the recipients messaging settings and their email format profile setting. These settings can cause the tester to spend a long time wondering why its not working correctly
        Hide
        Andreas Grabs added a comment -

        Hi Andrew,
        sorry, I thought that you are knowing about sending mails in moodle. I will respect this next time.
        Best regards
        Andreas

        Show
        Andreas Grabs added a comment - Hi Andrew, sorry, I thought that you are knowing about sending mails in moodle. I will respect this next time. Best regards Andreas
        Hide
        Dan Poltawski added a comment -

        Jolly good show!

        Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

        Tally-ho!

        Show
        Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: