Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32124

mails to non respondents are sent as plain text with html-tags

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.5, 2.2.2
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide

      You need a moodle instance with email support.

      1. Create a non-anonymous feedback instance in a course with one or more students
      2. Go to the "Show non-respondents" page
      3. Select one or more users
      4. Write a message with some html formatings like header, bold and so so.
      5. Send this mail.
        Now you should receive an email with a text and a html body.
      Show
      You need a moodle instance with email support. Create a non-anonymous feedback instance in a course with one or more students Go to the "Show non-respondents" page Select one or more users Write a message with some html formatings like header, bold and so so. Send this mail. Now you should receive an email with a text and a html body.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32124_master_wip

      Description

      If you send a mail to no respondents users with the editor integrated in the feedback module so the mail is sent in plain text but with html-tags.

        Gliffy Diagrams

          Activity

          grabs Andreas Grabs created issue -
          Hide
          salvetore Michael de Raadt added a comment -

          Hi, Anreas.

          I've just triaged this, but please don't let that stop you from working on it.

          Show
          salvetore Michael de Raadt added a comment - Hi, Anreas. I've just triaged this, but please don't let that stop you from working on it.
          salvetore Michael de Raadt made changes -
          Field Original Value New Value
          Fix Version/s STABLE backlog [ 10463 ]
          Labels triaged
          Affects Version/s 2.3 [ 10657 ]
          grabs Andreas Grabs made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          grabs Andreas Grabs made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/grabs/moodle/compare/master...MDL-32124_master_wip
          Pull Master Branch MDL-32124_master_wip
          Pull from Repository git://github.com/grabs/moodle.git
          Fix Version/s 2.1.6 [ 12052 ]
          Fix Version/s 2.2.3 [ 12053 ]
          Fix Version/s 2.3 [ 10657 ]
          Testing Instructions You need a moodle instance with email support.
          # Create a non-anonymous feedback instance in a course with one or more students
          # Go to the "Show non-respondents" page
          # Select one or more users
          # Write a message with some html formatings like header, bold and so so.
          # Send this mail.
          Now you should receive an email with a text and a html body.
          Pull 2.1 Branch MDL-32124_21_wip
          Pull 2.2 Diff URL https://github.com/grabs/moodle/compare/MOODLE_22_STABLE...MDL-32124_22_wip
          Pull 2.1 Diff URL https://github.com/grabs/moodle/compare/MOODLE_21_STABLE...MDL-32124_21_wip
          Pull 2.2 Branch MDL-32124_22_wip
          samhemelryk Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          samhemelryk Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks Andreas, this has been integrated now

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks Andreas, this has been integrated now
          samhemelryk Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Fix Version/s STABLE backlog [ 10463 ]
          Fix Version/s 2.3 [ 10657 ]
          salvetore Michael de Raadt made changes -
          Peer reviewer ankit_frenz
          salvetore Michael de Raadt made changes -
          Tester andyjdavis
          andyjdavis Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          andyjdavis Andrew Davis added a comment -

          Tested in master, 2.2 and 2.1.

          Just a word about the testing instructions. Make sure to include all settings that alter the behaviour of the code in question. The feedback message behaviour is also affected by the recipients messaging settings and their email format profile setting. These settings can cause the tester to spend a long time wondering why its not working correctly

          Show
          andyjdavis Andrew Davis added a comment - Tested in master, 2.2 and 2.1. Just a word about the testing instructions. Make sure to include all settings that alter the behaviour of the code in question. The feedback message behaviour is also affected by the recipients messaging settings and their email format profile setting. These settings can cause the tester to spend a long time wondering why its not working correctly
          andyjdavis Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          grabs Andreas Grabs added a comment -

          Hi Andrew,
          sorry, I thought that you are knowing about sending mails in moodle. I will respect this next time.
          Best regards
          Andreas

          Show
          grabs Andreas Grabs added a comment - Hi Andrew, sorry, I thought that you are knowing about sending mails in moodle. I will respect this next time. Best regards Andreas
          Hide
          poltawski Dan Poltawski added a comment -

          Jolly good show!

          Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale.

          Tally-ho!

          Show
          poltawski Dan Poltawski added a comment - Jolly good show! Your changes have made it into the Moodle release - its time to celebrate! I suggest a hot cup of English tea (with milk, no sugar) or a hoppy English ale. Tally-ho!
          poltawski Dan Poltawski made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 12/Apr/12

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12