Moodle
  1. Moodle
  2. MDL-32141

outdated TinyMCE in 2.1.x does not work in Firefox 11

    Details

    • Testing Instructions:
      Hide

      1/ test all our custom tinymce features - filepicker, spell, dragmath

      Show
      1/ test all our custom tinymce features - filepicker, spell, dragmath
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Rank:
      38864

      Description

      Very weird bug found today.

      Moodle 2.1.5+ (Build: 20120315) (bug does not affect other versions)
      Problem ONLY occurs with Mozilla Firefox (using version 11, Windows or Mac).
      No problem with MISE or Chrome.
      On Multiple Choice edit screen: all HTML edit boxes except Question Text display the problem.
      When clicking on all the HTLM edit boxes, impossible to enter the box to enter text. Instead, upon hovering over the edit boxes, this tooltip text is displayed:

      {#aria.rich_text_area} {#advanced.help_shortcut}

      (see attached)
      In order to be able to enter text in those boxes, I have to drag the "resize" tool at the bottom right of the boxes, and then the entry box becomes active.

        Issue Links

          Activity

          Hide
          Tim Hunt added a comment -

          We have been noticing this at the OU.

          It affects any form with more than one HTML editor.

          Show
          Tim Hunt added a comment - We have been noticing this at the OU. It affects any form with more than one HTML editor.
          Hide
          Petr Škoda added a comment -

          ok, I will try to backport editor from 2.2+add necessary core hacks, but I will need testers...

          Show
          Petr Škoda added a comment - ok, I will try to backport editor from 2.2+add necessary core hacks, but I will need testers...
          Hide
          Joseph Rézeau added a comment -

          Hi Tim, did you re-write some of my bug report? I don't mind at all, just curious to find my wording changed (for the best) so soon after I had posted it.
          Hope a solution will be found soon.
          ATB
          Joseph

          Show
          Joseph Rézeau added a comment - Hi Tim, did you re-write some of my bug report? I don't mind at all, just curious to find my wording changed (for the best) so soon after I had posted it. Hope a solution will be found soon. ATB Joseph
          Hide
          Petr Škoda added a comment -

          I managed to reproduce it on my comp, latest 2.2.x works, 2.1.x does not.

          Show
          Petr Škoda added a comment - I managed to reproduce it on my comp, latest 2.2.x works, 2.1.x does not.
          Hide
          Chris Follin added a comment -

          The description specifically mentions Firefox 11 for Windows. I just wanted to add that I am having the problem in Firefox 11 for Mac, too, and the resize trick still works as a workaround.

          Show
          Chris Follin added a comment - The description specifically mentions Firefox 11 for Windows. I just wanted to add that I am having the problem in Firefox 11 for Mac, too, and the resize trick still works as a workaround.
          Hide
          Karen Lilywhite added a comment -

          We found in one of our own apps we have built that has multiple tinyMCE editors on one screen and was experiencing the same issue, that when we updated tinyMCE to the most recent version this problem went away.

          Show
          Karen Lilywhite added a comment - We found in one of our own apps we have built that has multiple tinyMCE editors on one screen and was experiencing the same issue, that when we updated tinyMCE to the most recent version this problem went away.
          Hide
          Peter Friesen added a comment -

          We're seeing the same bug in
          Moodle 2.1.2+ (Build 20111027), whenever there are multiple HTML editors on the screen. Faculty run into it when they attempt to create a Multiple Choice question; students find it when taking a quiz that has more than one essay question on a page.

          Show
          Peter Friesen added a comment - We're seeing the same bug in Moodle 2.1.2+ (Build 20111027), whenever there are multiple HTML editors on the screen. Faculty run into it when they attempt to create a Multiple Choice question; students find it when taking a quiz that has more than one essay question on a page.
          Hide
          Huy Hoang added a comment -

          Moodle 2.0.7+ (20120309) is also affected. TinyMCE 3.4.9 in Moodle 2.2 doesn't have this problem.

          Show
          Huy Hoang added a comment - Moodle 2.0.7+ (20120309) is also affected. TinyMCE 3.4.9 in Moodle 2.2 doesn't have this problem.
          Hide
          Petr Škoda added a comment -

          Moodle 2.0.x is receiving only security fixes and support will end in few months - please consider upgrading your site.

          Show
          Petr Škoda added a comment - Moodle 2.0.x is receiving only security fixes and support will end in few months - please consider upgrading your site.
          Hide
          Emma Irwin added a comment -

          FF originally suggested upgrading TinyMCE (which sounds easy, but not often so for projects with customizations). I downloaded the nightly build (http://nightly.mozilla.org/) of FF resolves the problem .

          Show
          Emma Irwin added a comment - FF originally suggested upgrading TinyMCE (which sounds easy, but not often so for projects with customizations). I downloaded the nightly build ( http://nightly.mozilla.org/ ) of FF resolves the problem .
          Hide
          Joseph Rézeau added a comment -

          Just tested skodak's github Branch: w14_MDL-32141_m21_tinymce on my local Moodle 2.1 site, and HTML editor works as expected in Firefox 11.0.
          tested: filepicker and spell (I do not use dragmath)
          Thanks for the fix, skodak.
          Joseph

          Show
          Joseph Rézeau added a comment - Just tested skodak's github Branch: w14_ MDL-32141 _m21_tinymce on my local Moodle 2.1 site, and HTML editor works as expected in Firefox 11.0. tested: filepicker and spell (I do not use dragmath) Thanks for the fix, skodak. Joseph
          Hide
          Don Hazelwood added a comment - - edited

          nvm

          Show
          Don Hazelwood added a comment - - edited nvm
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Aparup Banerjee added a comment - - edited

          Hi,
          quick note on the patch : lang/en/admin.php has duplicate "$string['spellengine'] = 'Spell engine';"

          Show
          Aparup Banerjee added a comment - - edited Hi, quick note on the patch : lang/en/admin.php has duplicate "$string ['spellengine'] = 'Spell engine';"
          Hide
          Petr Škoda added a comment -

          arrgh, fixing

          Show
          Petr Škoda added a comment - arrgh, fixing
          Hide
          Petr Škoda added a comment -

          fix pushed to repo, thanks a lot

          Show
          Petr Škoda added a comment - fix pushed to repo, thanks a lot
          Hide
          Aparup Banerjee added a comment -

          linking previous backport (22) issue for tinymce

          Show
          Aparup Banerjee added a comment - linking previous backport (22) issue for tinymce
          Hide
          Aparup Banerjee added a comment -

          thanks thats integrated into MOODLE_21_STABLE
          i've also added a commit updating lib/thirdpartylibs.xml to '3.4.9'

          ready for testing. i suggest all QA tests related to tiny mce but note that this tinymce version has been backported slowly. see MDL-30636 and then MDL-31913 for history.

          Show
          Aparup Banerjee added a comment - thanks thats integrated into MOODLE_21_STABLE i've also added a commit updating lib/thirdpartylibs.xml to '3.4.9' ready for testing. i suggest all QA tests related to tiny mce but note that this tinymce version has been backported slowly. see MDL-30636 and then MDL-31913 for history.
          Hide
          Jason Fowler added a comment -

          Looks good to me, and I learned a bit about the dragmath stuff

          Show
          Jason Fowler added a comment - Looks good to me, and I learned a bit about the dragmath stuff
          Hide
          Aparup Banerjee added a comment -

          The code here has been spread to upstream moodle repositories and mirrors for anyone to use .

          Closing, have a good weekend!

          Show
          Aparup Banerjee added a comment - The code here has been spread to upstream moodle repositories and mirrors for anyone to use . Closing, have a good weekend!

            People

            • Votes:
              21 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: