Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.2
-
Component/s: Backup
-
Testing Instructions:
- From Settings -> Course Administration choose Backup
- Upload the attached .mbz file
- Click the 'Restore' button
- On the first page Confirm that:
- The 'Type' now shows 'Section'
-
Difficulty:Easy
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull Master Branch:
MDL-32142-master-1
Description
Restoring a section throws a warning about missing language string:
Invalid get_string() identifier: 'backuptypesection' or component 'backup'. Perhaps you are missing $string['backuptypesection'] = ''; in lang/en/backup.php?
|
line 6367 of /lib/moodlelib.php: call to debugging()
|
line 6959 of /lib/moodlelib.php: call to core_string_manager->get_string()
|
line 82 of /backup/util/ui/renderer.php: call to get_string()
|
line 202 of /backup/util/ui/restore_ui_stage.class.php: call to core_backup_renderer->backup_details()
|
line 67 of /backup/restore.php: call to restore_ui_stage_confirm->display()
|
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Looks fine, but I don't think its necessary to get the tester to go through all those steps installing backup handler. Testers time is precious.
Providing them with a backup file to test with is sufficient.
Thanks Andrew, this has been integrated now.
Tested pre and post patch. Looks good. No missing language string was produced with the patch.
Thanks.
Thanks for spotting that.
It looks like you're keen to work on this, so don't let us get in the way.