Moodle
  1. Moodle
  2. MDL-32142

Missing language string backuptypesection in lang/en/backup.php

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Minor Minor
        • Resolution: Fixed
        • Affects Version/s: 2.2.2
        • Fix Version/s: 2.1.6, 2.2.3
        • Component/s: Backup
        • Labels:

          Description

          Restoring a section throws a warning about missing language string:

          Invalid get_string() identifier: 'backuptypesection' or component 'backup'. Perhaps you are missing $string['backuptypesection'] = ''; in lang/en/backup.php?
          		 
          line 6367 of /lib/moodlelib.php: call to debugging()
          		 
          line 6959 of /lib/moodlelib.php: call to core_string_manager->get_string()
          		 
          line 82 of /backup/util/ui/renderer.php: call to get_string()
          		 
          line 202 of /backup/util/ui/restore_ui_stage.class.php: call to core_backup_renderer->backup_details()
          		 
          line 67 of /backup/restore.php: call to restore_ui_stage_confirm->display()

            Gliffy Diagrams

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Michael de Raadt added a comment -

              Thanks for spotting that.

              It looks like you're keen to work on this, so don't let us get in the way.

              Show
              Michael de Raadt added a comment - Thanks for spotting that. It looks like you're keen to work on this, so don't let us get in the way.
              Hide
              Permalink
              Dan Poltawski added a comment -

              Looks fine, but I don't think its necessary to get the tester to go through all those steps installing backup handler. Testers time is precious.

              Providing them with a backup file to test with is sufficient.

              Show
              Dan Poltawski added a comment - Looks fine, but I don't think its necessary to get the tester to go through all those steps installing backup handler. Testers time is precious. Providing them with a backup file to test with is sufficient.
              Hide
              Permalink
              Sam Hemelryk added a comment -

              Thanks Andrew, this has been integrated now.

              Show
              Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now.
              Hide
              Permalink
              Adrian Greeve added a comment -

              Tested pre and post patch. Looks good. No missing language string was produced with the patch.
              Thanks.

              Show
              Adrian Greeve added a comment - Tested pre and post patch. Looks good. No missing language string was produced with the patch. Thanks.
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              And this has landed upstream, finally! Yay!

              תודה רבה && شكرا جزيلا



              Closing, ciao

              Show
              Eloy Lafuente (stronk7) added a comment - And this has landed upstream, finally! Yay! תודה רבה && شكرا جزيلا Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: