Details

    • Type: New Feature
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.2, 2.3
    • Fix Version/s: 2.3
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Base Moodle install. All icons should appear normally in all themes.
      Create course and place a forum in the course. Edit icons and Forum icon should appear normally.

      Enable themedesignermode - This just forces moodle to re-check the icon locations instead of using its cache

      In dataroot, create pix and pix_plugins

      • For core icons
        In dataroot/pix, create a folder 'i'
        Copy dirroot/pix/i/risk_spam.gif to dataroot/pix/i/edit.gif
        Load a course, you should now see an yellow triangle next to the course editing link.
        All other icons should stay the same.
      • For plugin icons
        In dataroot/pix_plugins, create mod/forum.
        Copy dirroot/pix/i/risk_xss.gif to dataroot/pix_plugins/mod/forum/icon.gif
        Reload the page. You should now see a red triangle next to the forum.
      • To verify that theme override takes precedence.
        Switch theme to afterburner.
        Reload the course. The edit and forum icons should appear as the normal afterburner icons for those items, since afterburner includes its own versions.
      Show
      Base Moodle install. All icons should appear normally in all themes. Create course and place a forum in the course. Edit icons and Forum icon should appear normally. Enable themedesignermode - This just forces moodle to re-check the icon locations instead of using its cache In dataroot, create pix and pix_plugins For core icons In dataroot/pix, create a folder 'i' Copy dirroot/pix/i/risk_spam.gif to dataroot/pix/i/edit.gif Load a course, you should now see an yellow triangle next to the course editing link. All other icons should stay the same. For plugin icons In dataroot/pix_plugins, create mod/forum. Copy dirroot/pix/i/risk_xss.gif to dataroot/pix_plugins/mod/forum/icon.gif Reload the page. You should now see a red triangle next to the forum. To verify that theme override takes precedence. Switch theme to afterburner. Reload the course. The edit and forum icons should appear as the normal afterburner icons for those items, since afterburner includes its own versions.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      I feel like this has to have come up before, but I've looked through ~400 tickets and haven't found it.

      It would be great if there was a pix store in dataroot that would just override base. Much the same way dataroot/lang overrides the base language translations.

      E.G.: We have an icon that we want to replace a base icon in all themes (that don't override it themselves). Right now, as far as I can tell, we have to replace the icon in dirroot/pix/. We like to make as few changes in the dirroot as possible for hopefully obvious reasons.

      I would be happy to work on the patch for this, but if it's too likely to get reject on some principle, I won't bother, so I want to run it by the people that know the most about this area.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  3 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12