Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32164

'encoding' string missing in database activity import form

    Details

    • Testing Instructions:
      Hide
      • Create a new Database activity
      • Define basic fields and templates
      • From Settings choose Database activity administration -> Import entries
      • Confirm:
        • The 'File Encoding' string is present and no errors are displayed
      Show
      Create a new Database activity Define basic fields and templates From Settings choose Database activity administration -> Import entries Confirm: The 'File Encoding' string is present and no errors are displayed
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-32164-master-2

      Description

      The string for 'encoding' is missing on the Database Activity's import form

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dobedobedoh Andrew Nicols added a comment -

              The encoding string was moved when user upload strings were moved out of admin.

              It may be that it's preferential to move this encoding string to mod/data rather than keeping it in lang/en/admin.php

              Show
              dobedobedoh Andrew Nicols added a comment - The encoding string was moved when user upload strings were moved out of admin. It may be that it's preferential to move this encoding string to mod/data rather than keeping it in lang/en/admin.php
              Hide
              poltawski Dan Poltawski added a comment -

              David, adding you as peer reviewer here because i'm never really certain what is the best solution here for translators.

              Should the string be self contained in mod/data and then use amos scripts to CPY the existing string into new string?

              Would be interested in knowing what our best practice should be

              Show
              poltawski Dan Poltawski added a comment - David, adding you as peer reviewer here because i'm never really certain what is the best solution here for translators. Should the string be self contained in mod/data and then use amos scripts to CPY the existing string into new string? Would be interested in knowing what our best practice should be
              Hide
              mudrd8mz David Mudrák added a comment -

              Well, it really depends case to case. I found the same string in grades.php for example, too.

              en/grades.php:$string['encoding'] = 'Encoding';

              Here, I would use the original string (now living in tool_uploaduser) and CPY it into mod_data.

              Show
              mudrd8mz David Mudrák added a comment - Well, it really depends case to case. I found the same string in grades.php for example, too. en/grades.php:$string['encoding'] = 'Encoding'; Here, I would use the original string (now living in tool_uploaduser) and CPY it into mod_data.
              Hide
              dobedobedoh Andrew Nicols added a comment -

              I've made the following changes based on David's comments:

              • moved the encoding to mod/data
              • renamed it as fileencoding
              • added AMOS commands to copy over from the location it was stolen from

              I've provided branches for master and 2.2.
              2.1 is unaffected

              Show
              dobedobedoh Andrew Nicols added a comment - I've made the following changes based on David's comments: moved the encoding to mod/data renamed it as fileencoding added AMOS commands to copy over from the location it was stolen from I've provided branches for master and 2.2. 2.1 is unaffected
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Hi David,

              Any chance that you could glance your eye over this and check that it's correct - particularly the AMOS commands?

              Cheers,

              Andrew

              Show
              dobedobedoh Andrew Nicols added a comment - Hi David, Any chance that you could glance your eye over this and check that it's correct - particularly the AMOS commands? Cheers, Andrew
              Hide
              mudrd8mz David Mudrák added a comment -

              +1 both patch and the AMOScript looking good, thanks Andrew!

              Show
              mudrd8mz David Mudrák added a comment - +1 both patch and the AMOScript looking good, thanks Andrew!
              Hide
              dobedobedoh Andrew Nicols added a comment -

              Should rebase cleanly still

              Show
              dobedobedoh Andrew Nicols added a comment - Should rebase cleanly still
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Andrew, this has been integrated now

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Andrew, this has been integrated now
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              works as expected.
              passing
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - works as expected. passing Thanks
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome?

              Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U

              Closing, ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This is now part of Moodle and a few millions people around the globe will be using it soon. Isn't that awesome? Many, many thanks and don't forget http://youtu.be/4N7dPaP5Z8U Closing, ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    14/May/12